This repository has been archived by the owner on Apr 17, 2019. It is now read-only.
* Fix operator== for signatures type in old-fashion model and sh_m #1302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luckychess
approved these changes
May 4, 2018
| /** | ||
| * @given Transaction with marked signature | ||
| * @when Invoke ::addSignature with same public key but different signed | ||
| * @then Expect that second signature doesn't added |
| /** | ||
| * @given Block with marked signature | ||
| * @when Invoke ::addSignature with same public key but different signed | ||
| * @then Expect that second signature doesn't added |
There was a problem hiding this comment.
Same (doesn't -> wasn't)
| shared_model::crypto::PublicKey("key_one"))); | ||
| ASSERT_FALSE(block.addSignature(shared_model::crypto::Signed("sign_two"), | ||
| shared_model::crypto::PublicKey("key_one"))); | ||
| } |
| } | ||
|
|
||
| /** | ||
| * @given Transaction with marked signature |
There was a problem hiding this comment.
I think better to use "given" instead of "marked".
Or may be even move everything about transaction to "when" part (e. g. given transaction, when addSignature() invoked twice with ...)
| } | ||
|
|
||
| /** | ||
| * @given Block with marked signature |
There was a problem hiding this comment.
See note about "marked" from previous test.
l4l
approved these changes
May 4, 2018
| #include "module/shared_model/builders/protobuf/test_transaction_builder.hpp" | ||
|
|
||
| /** | ||
| * @given Two signatures with same pub key but different signed |
There was a problem hiding this comment.
In terms of sm_m objects Signature is a pair: PubKey × Signed. Here I want to reflect different signed explicitly.
* Fix ::addSignature for tx and block Signed-off-by: Fedor Muratov <muratovfyodor@yandex.ru>
Signed-off-by: Fedor Muratov <muratovfyodor@yandex.ru>
Signed-off-by: Fedor Muratov <muratovfyodor@yandex.ru>
muratovv
force-pushed
the
fix/model_sigantures
branch
from
13787a4
to
c20deb0
Compare
…ransaction Signed-off-by: Fedor Muratov <muratovfyodor@yandex.ru>
* Fix rebase issues: add const ref for tx and block, also, fix clang-format Signed-off-by: Fedor Muratov <muratovfyodor@yandex.ru>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Benefits
Close potential security issues for Iroha's stateless validation.
Usage Examples or Tests [optional]
Tests are provided.