This repository has been archived by the owner on Apr 17, 2019. It is now read-only.
Refactor TransferAsset acceptance test #1482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l4l
added
needs-review
- Add IntegrationTestFramework::sendTxAwait - Reuse AcceptanceFixture primitive in TA test - Move out primitive methods in fixture - Fix WithOnlyCanTransferPerm/WithOnlyCanReceivePerm tests Signed-off-by: Kitsu <mail@kitsu.me>
l4l
force-pushed
the
fix/transfer_asset_refactor
branch
from
f766c30
to
a701b3a
Compare
igor-egorov
suggested changes
Jun 21, 2018
| * @when execute tx with TransferAsset command | ||
| * @then there is an empty proposal | ||
| */ | ||
| TEST_F(TransferAsset, WithOnlyCanTransferPerm) { | ||
| TEST_F(TransferAsset, DISABLED_WithOnlyCanTransferPerm) { |
There was a problem hiding this comment.
Please specify in a comment the reason why the test is disabled. If the test can be enabled only after resolution of some other issue, denote it as a todo comment with Jira task id.
| * @when execute tx with TransferAsset command | ||
| * @then there is an empty proposal | ||
| */ | ||
| TEST_F(TransferAsset, WithOnlyCanReceivePerm) { | ||
| TEST_F(TransferAsset, DISABLED_WithOnlyCanReceivePerm) { |
There was a problem hiding this comment.
Please specify in a comment the reason why the test is disabled. If the test can be enabled only after resolution of some other issue, denote it as a todo comment with Jira task id.
| .sendTxAwait(create_asset, check(1)) | ||
| .sendTxAwait(add_assets, check(1)) | ||
| .sendTxAwait(make_transfer, check(1)) | ||
| .sendQuery(make_query(kUserId), check_balance(kUserId, kLeft)) | ||
| .sendQuery(make_query(kUser2Id), check_balance(kUser2Id, kForTransfer)) |
There was a problem hiding this comment.
Despite the test does not fail, both queries (lines 378, 379) cause postgres' errors:
[2018-06-21 22:45:45.536809398][th:20689][info] IntegrationTestFramework send query
[2018-06-21 22:45:45.543091771][th:20689][error] PostgresWsvQuery ERROR: invalid input value for enum grantable_perm: ""
LINE 1: ...dmin@test' AND account_id = 'user@test' AND permission = '';
^
[2018-06-21 22:45:45.544989785][th:20689][info] IntegrationTestFramework send query
[2018-06-21 22:45:45.552626695][th:20689][error] PostgresWsvQuery ERROR: invalid input value for enum grantable_perm: ""
LINE 1: ...n@test' AND account_id = 'usertwo@test' AND permission = '';
^
There was a problem hiding this comment.
Will be resolved with IR-1464
luckychess
suggested changes
Jun 22, 2018
| .finish()) | ||
| .checkBlock( | ||
| [](auto &block) { ASSERT_EQ(block->transactions().size(), 0); }) | ||
| .sendTxAwait(makeFirstUser(), check(1)) |
There was a problem hiding this comment.
Currently this test doesn't work for both me and CI, fix it please.
| @@ -94,7 +94,7 @@ auto AcceptanceFixture::baseTx() | |||
|
|
|||
| auto AcceptanceFixture::baseQry() | |||
| -> decltype(base(TestUnsignedQueryBuilder())) { | |||
| return base(TestUnsignedQueryBuilder()); | |||
| return base(TestUnsignedQueryBuilder()).queryCounter(tx_counter); | |||
There was a problem hiding this comment.
Plz rename tx_counter -> query_counter.
There was a problem hiding this comment.
There's the same counter for both tx and query, I may rename it to just counter
Signed-off-by: Kitsu <mail@kitsu.me>
l4l
force-pushed
the
fix/transfer_asset_refactor
branch
from
121698e
to
d02f4f5
Compare
Signed-off-by: Kitsu <mail@kitsu.me>
igor-egorov
approved these changes
Jun 25, 2018
There was a problem hiding this comment.
Was able to compile only with the fix:
iff --git a/irohad/synchronizer/CMakeLists.txt b/irohad/synchronizer/CMakeLists.txt
index 1f31648..f27f01e 100644
--- a/irohad/synchronizer/CMakeLists.txt
+++ b/irohad/synchronizer/CMakeLists.txt
@@ -3,7 +3,7 @@ add_library(synchronizer
)
target_link_libraries(synchronizer
- shared_model_interfaces
+ shared_model_proto_backend
rxcpp
logger
)
luckychess
approved these changes
Jun 25, 2018
Signed-off-by: Kitsu <mail@kitsu.me>
l4l
added a commit
that referenced
this pull request
Jul 25, 2018
- Add IntegrationTestFramework::sendTxAwait - Reuse AcceptanceFixture primitive in TA test - Move out primitive methods in fixture - Fix (and rename accordingly) WithOnlyCanTransferPerm/WithOnlyCanReceivePerm tests - Rename tx_counter in AcceptanceFixture Signed-off-by: Kitsu <mail@kitsu.me>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Also, I've tried to remove
Role::kAddAssetQtyfrom the first user but it seems to have some bug. Feel free to review/comment it as wellBenefits
Lesser simpler code -> lesser bugs
Possible Drawbacks
None?
Usage Examples or Tests
make transfer_asset_test && test_bin/transfer_asset_test