This repository has been archived by the owner on Apr 17, 2019. It is now read-only.
Remove hasAccountGrantablePermissions in qry exec #1500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kitsu <mail@kitsu.me>
l4l
added
needs-review
Signed-off-by: Kitsu <mail@kitsu.me>
Alexey-N-Chernyshov
approved these changes
Jun 26, 2018
Akvinikym
approved these changes
Jun 26, 2018
l4l
added a commit
that referenced
this pull request
Jul 25, 2018
Signed-off-by: Kitsu <mail@kitsu.me>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
For some reason Queries are checked against Grantable permissions (Grantable are only for commands). This pr removes redundant code (checking in execution, checking in EXPECT_CALL's, test for grantable perms) also
permissions::permissionOfremoval is thereBenefits
The lesser useless code the happier people are
Possible Drawbacks
None?