This repository has been archived by the owner on Apr 17, 2019. It is now read-only.
Remove account_id from Add/Subtract commands #1511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kitsu <mail@kitsu.me>
Signed-off-by: Kitsu <mail@kitsu.me>
l4l
added
needs-review
Alexey-N-Chernyshov
approved these changes
Jun 29, 2018
| @@ -217,7 +215,6 @@ namespace shared_model { | |||
| * @return builder with subtract asset quantity command appended | |||
| */ | |||
| ModelTransactionBuilder subtractAssetQuantity( | |||
There was a problem hiding this comment.
Please, fix method description here as well.
Signed-off-by: Kitsu <mail@kitsu.me>
|
SonarQube analysis reported 3 issues
|
|
@igor-egorov @Alexey-N-Chernyshov commit d1d7c55 build status: SUCCESS. build URL: https://jenkins.soramitsu.co.jp/job/iroha/job/iroha-hyperledger/job/PR-1511/3/ |
Signed-off-by: Kitsu <mail@kitsu.me>
|
@igor-egorov @Alexey-N-Chernyshov commit 71629f7 build status: SUCCESS. build URL: https://jenkins.soramitsu.co.jp/job/iroha/job/iroha-hyperledger/job/PR-1511/4/ |
igor-egorov
approved these changes
Jun 30, 2018
This was referenced Jul 19, 2018
l4l
added a commit
that referenced
this pull request
Jul 25, 2018
Signed-off-by: Kitsu <mail@kitsu.me>
l4l
added a commit
that referenced
this pull request
Jul 25, 2018
Signed-off-by: Kitsu <mail@kitsu.me>
l4l
added a commit
that referenced
this pull request
Jul 25, 2018
Signed-off-by: Kitsu <mail@kitsu.me>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
AddAssetQuantity&SubtractAssetQuantityhad uselessaccount_idfield that is required to be equal to the tx creator (otherwise it will causes stateless fail). In this pr:Benefits
Cleaner API
Possible Drawbacks
None?