-
Notifications
You must be signed in to change notification settings - Fork 297
Fix tests for createRole with empty set of permissions #1520
Conversation
@lebdron @l4l commit ecc1fa5 build status: SUCCESS. build URL: https://jenkins.soramitsu.co.jp/job/iroha/job/iroha-hyperledger/job/PR-1520/1/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please rebase before merge
ecc1fa5
to
76d23c9
Compare
@lebdron @l4l commit 76d23c9 build status: UNSTABLE. build URL: https://jenkins.soramitsu.co.jp/job/iroha/job/iroha-hyperledger/job/PR-1520/2/ |
@lebdron @l4l commit 76d23c9 build status: UNSTABLE. build URL: https://jenkins.soramitsu.co.jp/job/iroha/job/iroha-hyperledger/job/PR-1520/3/ |
@lebdron @l4l commit 76d23c9 build status: SUCCESS. build URL: https://jenkins.soramitsu.co.jp/job/iroha/job/iroha-hyperledger/job/PR-1520/4/ |
I have faced with the issue about
How can I fix it? |
@muratovv it seems that you're using non-patched swig, please use either downloaded by the cmake, or patch yourself (in patch folder) |
Signed-off-by: Igor Egorov <igor@soramitsu.co.jp>
76d23c9
to
3b6fdbf
Compare
@lebdron @l4l commit 3b6fdbf build status: FAILURE. build URL: https://jenkins.soramitsu.co.jp/job/iroha/job/iroha-hyperledger/job/PR-1520/8/ |
Signed-off-by: Igor Egorov <igor@soramitsu.co.jp> The behavior of createRole command was changed, so the tests had to be updated.
The behavior of createRole command was changed, so the tests had to be updated. Signed-off-by: Igor Egorov <igor@soramitsu.co.jp>
The behavior of createRole command was changed, so the tests had to be updated. Signed-off-by: Igor Egorov <igor@soramitsu.co.jp>
Signed-off-by: Igor Egorov igor@soramitsu.co.jp
Description of the Change
The behavior of createRole command was changed, so the tests had to be updated.
Benefits
Fixed tests.
Possible Drawbacks
None ?
Usage Examples or Tests