Skip to content
This repository has been archived by the owner on Apr 17, 2019. It is now read-only.

Fix tests for createRole with empty set of permissions #1520

Merged
merged 1 commit into from
Jul 3, 2018

Conversation

igor-egorov
Copy link
Contributor

Signed-off-by: Igor Egorov igor@soramitsu.co.jp

Description of the Change

The behavior of createRole command was changed, so the tests had to be updated.

Benefits

Fixed tests.

Possible Drawbacks

None ?

Usage Examples or Tests

cmake -H. -Bbuild -DSWIG_PYTHON=ON -DSWIG_JAVA=ON -DSWIG_NODE=ON
cmake --build build --target irohajava
cmake --build build --target irohapy
cmake --build build --target python_tests
cmake --build build --target irohanode
cd build
ctest -R "(java|python)" --output-on-failure

@igor-egorov igor-egorov added needs-review pr awaits review from maintainers SDK Anything related to the client bindings labels Jun 29, 2018
@igor-egorov igor-egorov requested review from l4l and lebdron June 29, 2018 18:25
@sorabot
Copy link

sorabot commented Jun 29, 2018

Copy link
Contributor

@l4l l4l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please rebase before merge

@igor-egorov igor-egorov force-pushed the fix/tests-create-role-empty-perms branch from ecc1fa5 to 76d23c9 Compare June 30, 2018 10:33
@sorabot
Copy link

sorabot commented Jun 30, 2018

@sorabot
Copy link

sorabot commented Jun 30, 2018

@sorabot
Copy link

sorabot commented Jun 30, 2018

@l4l l4l removed the needs-review pr awaits review from maintainers label Jun 30, 2018
@muratovv
Copy link
Contributor

I have faced with the issue about irohanode.

[100%] Building CXX object shared_model/bindings/CMakeFiles/irohanode.dir/bindingsJAVASCRIPT_wrap.o
/Users/fyodormuratov/Documents/dev/soramitsu/iroha/build/shared_model/bindings/bindingsJAVASCRIPT_wrap.cxx:966:27: error: no template named 'WeakCallbackData'
      in namespace 'v8'; did you mean 'WeakCallbackInfo'?
  void (*dtor) (const v8::WeakCallbackData<v8::Object, SWIGV8_Proxy> &data);
                      ~~~~^~~~~~~~~~~~~~~~
                          WeakCallbackInfo
/usr/local/include/node/v8.h:8175:16: note: 'WeakCallbackInfo' declared here
  friend class WeakCallbackInfo;
               ^

How can I fix it?

@l4l
Copy link
Contributor

l4l commented Jun 30, 2018

@muratovv it seems that you're using non-patched swig, please use either downloaded by the cmake, or patch yourself (in patch folder)

Signed-off-by: Igor Egorov <igor@soramitsu.co.jp>
@igor-egorov igor-egorov force-pushed the fix/tests-create-role-empty-perms branch from 76d23c9 to 3b6fdbf Compare July 3, 2018 08:13
@igor-egorov igor-egorov merged commit 813613b into develop Jul 3, 2018
@igor-egorov igor-egorov deleted the fix/tests-create-role-empty-perms branch July 3, 2018 08:14
@sorabot
Copy link

sorabot commented Jul 3, 2018

l4l pushed a commit that referenced this pull request Jul 25, 2018
Signed-off-by: Igor Egorov <igor@soramitsu.co.jp>

The behavior of createRole command was changed, so the tests had to be updated.
l4l pushed a commit that referenced this pull request Jul 25, 2018
The behavior of createRole command was changed, so the tests had to be updated.

Signed-off-by: Igor Egorov <igor@soramitsu.co.jp>
l4l pushed a commit that referenced this pull request Jul 25, 2018
The behavior of createRole command was changed, so the tests had to be updated.

Signed-off-by: Igor Egorov <igor@soramitsu.co.jp>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
SDK Anything related to the client bindings
Development

Successfully merging this pull request may close these issues.

None yet

5 participants