Skip to content
This repository has been archived by the owner on Apr 17, 2019. It is now read-only.

BFT OS components #1703

Merged
merged 12 commits into from
Sep 4, 2018
Merged

BFT OS components #1703

merged 12 commits into from
Sep 4, 2018

Conversation

lebdron
Copy link
Contributor

@lebdron lebdron commented Aug 31, 2018

Description of the Change

Includes the following changes:

  • YAC refactoring with states instead of vote, commit, and reject
  • Transaction batch factory separated from transaction batch
  • BFT OS components: On-demand ordering service, client and server gRPC transport, connection manager, and ordering gate

Benefits

One step towards CFT and BFT

Possible Drawbacks

None

@lebdron
BFT OS trunk
ed7b375 
Signed-off-by: Andrei Lebedev <lebdron@gmail.com>
@lebdron
Proposal gate and proposal hash provider (#1623)
c89bd5f 
Signed-off-by: Andrei Lebedev <lebdron@gmail.com>
@lebdron
On demand OS transport (#1635)
7ab8e34 
Signed-off-by: Andrei Lebedev <lebdron@gmail.com>
@lebdron
On demand OS connection manager (#1645)
273aed0 
* Communication manager

* Add peers to ctor

* Fix ctor deadlock

* Add missing link libraries

Signed-off-by: Andrei Lebedev <lebdron@gmail.com>
@lebdron
Add missing peer to on-demand OS connection manager (#1665)
da28210 
Signed-off-by: Andrei Lebedev <lebdron@gmail.com>
@lebdron
Fix BFT OS algorithm and interfaces (#1670)
99e8c16 
Signed-off-by: Andrei Lebedev <lebdron@gmail.com>
@lebdron
Remove proposal gate (#1700)
562c2f1 
Signed-off-by: Andrei Lebedev <lebdron@gmail.com>
@lebdron
On-demand ordering gate and related fixes (#1675)
ba05083 
Signed-off-by: Andrei Lebedev <lebdron@gmail.com>
@lebdron
Merge branch 'dev' into trunk/bft-os
5841c2c 
Signed-off-by: Andrei Lebedev <lebdron@gmail.com>
kamilsa
kamilsa reviewed Sep 3, 2018
View reviewed changes
Copy link
Contributor

@kamilsa kamilsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider fixing small issues before merge

irohad/consensus/yac/impl/yac_crypto_provider_impl.hpp Outdated
bool verify(RejectMessage msg) override;

bool verify(VoteMessage msg) override;
bool verify(std::vector<VoteMessage> msg) override;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not const ref?

irohad/consensus/yac/transport/impl/network_impl.hpp Outdated
@@ -18,6 +18,7 @@
#ifndef IROHA_NETWORK_IMPL_HPP
#define IROHA_NETWORK_IMPL_HPP

#include <consensus/yac/messages.hpp>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use ""

@lebdron
Merge branch 'dev' into trunk/bft-os
149fb79 
Signed-off-by: Andrei Lebedev <lebdron@gmail.com>
@lebdron
Review fixes
2c2be8f 
Signed-off-by: Andrei Lebedev <lebdron@gmail.com>
@sorabot
Copy link

sorabot commented Sep 3, 2018

SonarQube analysis reported 8 issues

  1. MINOR interactive_common_cli.cpp#L43: Return value of function to_string() is not used. rule
  2. MINOR yac_gate_impl.hpp#L68: Unused private function: 'YacGateImpl::copySignatures' rule
  3. MINOR yac.hpp#L92: Unused private function: 'Yac::applyState' rule
  4. MINOR ordering_init.cpp#L59: The function 'initOrderingGate' is never used. rule
  5. MINOR on_demand_ordering_service_impl.hpp#L57: Unused private function: 'OnDemandOrderingServiceImpl::packNextProposals' rule
  6. MINOR on_demand_ordering_service_impl.hpp#L64: Unused private function: 'OnDemandOrderingServiceImpl::tryErase' rule
  7. MINOR ordering_gate_service_test.cpp#L49: Variable 'factory_' is assigned in constructor body. Consider performing initialization in initialization list. rule
  8. MINOR ordering_gate_service_test.cpp#L51: Variable 'pcs_' is assigned in constructor body. Consider performing initialization in initialization list. rule

@lebdron lebdron merged commit 6b05736 into dev Sep 4, 2018
@lebdron lebdron deleted the trunk/bft-os branch September 4, 2018 04:14
nickaleks pushed a commit that referenced this pull request Sep 10, 2018
@lebdron @nickaleks
BFT OS components (#1703)
3945302 
* BFT OS trunk

* On demand OS transport (#1635)

* On demand OS connection manager (#1645)

* On-demand ordering gate and related fixes (#1675)

Signed-off-by: Andrei Lebedev <lebdron@gmail.com>
@kamilsa kamilsa mentioned this pull request Nov 1, 2018
Closed
bakhtin pushed a commit that referenced this pull request Nov 2, 2018
@lebdron @bakhtin
BFT OS components (#1703)
0c60db5 
* BFT OS trunk

* On demand OS transport (#1635)

* On demand OS connection manager (#1645)

* On-demand ordering gate and related fixes (#1675)

Signed-off-by: Andrei Lebedev <lebdron@gmail.com>
@neewy neewy mentioned this pull request Nov 2, 2018
Closed
@kamilsa kamilsa mentioned this pull request Dec 12, 2018
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@muratovv muratovv muratovv approved these changes

@kamilsa kamilsa kamilsa approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lebdron @sorabot @muratovv @kamilsa