This repository has been archived by the owner on Apr 17, 2019. It is now read-only.
Fix storage connection disposal #1727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igor-egorov
approved these changes
Sep 18, 2018
| std::unique_ptr<soci::session> sql, | ||
| std::shared_ptr<shared_model::interface::CommonObjectsFactory> factory) | ||
| : psql_(std::move(sql)), | ||
| sql_(*psql_), |
There was a problem hiding this comment.
Please leave a todo about plans to change the way of soci::session storing.
There was a problem hiding this comment.
Signed-off-by: Andrei Lebedev <lebdron@gmail.com>
lebdron
force-pushed
the
fix/storage-connection-disposal
branch
from
7ad6271
to
1b16c10
Compare
kamilsa
approved these changes
Sep 19, 2018
Signed-off-by: Andrei Lebedev <lebdron@gmail.com>
|
SonarQube analysis reported 3 issues
|
bakhtin
pushed a commit
that referenced
this pull request
Nov 2, 2018
* Remove session shared_ptrs; add freeConnections method * Add todo for soci::session fields Signed-off-by: Andrei Lebedev <lebdron@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Add freeConnections method, which disposes all currently used connections. Due to storage shared pointer not being released in irohad destructor, method has to be manually called in irohad destructor.
Benefits
No more leftover databases after tests, since they drop without issues now.
Possible Drawbacks
Storage shared pointer is still used by some components. It should be verified that all components are destroyed when irohad destructor is called.