This repository has been archived by the owner on Apr 17, 2019. It is now read-only.
MST fuzzing #1845
Merged
MST fuzzing #1845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igor-egorov
approved these changes
Nov 13, 2018
lebdron
reviewed
Nov 13, 2018
| shared_model::interface::Transaction>> | ||
| tx_validator = | ||
| std::make_unique<shared_model::validation:: | ||
| DefaultOptionalSignedTransactionValidator>(); |
There was a problem hiding this comment.
The problem with this approach is that the possible changes in application.cpp will not be reflected in this file. Please think of a solution where components in application.cpp are referenced here.
There was a problem hiding this comment.
After discussion with @igor-egorov we decided to leave TODO and fix this issue later since it affect other tasks too.
nickaleks
approved these changes
Nov 14, 2018
Signed-off-by: Konstantin Munichev <toobwn@gmail.com>
luckychess
force-pushed
the
feature/mst_fuzzing
branch
from
fa3b6ef
to
b79030c
Compare
Signed-off-by: Konstantin Munichev <toobwn@gmail.com>
luckychess
force-pushed
the
feature/mst_fuzzing
branch
from
b79030c
to
3f0b667
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Fuzzing for MST endpoint (SendState).
Benefits
One more endpoint covered.
Possible Drawbacks
CI is needed.
Also it looks like a false positive warning from Address Sanitizer (at least I couldn't find a problem - see https://gist.github.com/luckychess/b65bd40e958887273e86a0a535cc896d).
Usage Examples or Tests