This repository has been archived by the owner on Apr 17, 2019. It is now read-only.
Replay prevention on proposal generation #1857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nikita Alekseev <n.alekseev2104@gmail.com>
…edger/iroha into feature/replay_proposal_generation
Signed-off-by: Nikita Alekseev <n.alekseev2104@gmail.com>
Signed-off-by: Nikita Alekseev <n.alekseev2104@gmail.com>
Signed-off-by: Nikita Alekseev <n.alekseev2104@gmail.com>
Signed-off-by: Nikita Alekseev <n.alekseev2104@gmail.com>
Signed-off-by: Nikita Alekseev <n.alekseev2104@gmail.com>
Akvinikym
suggested changes
Nov 15, 2018
| }, | ||
| [this](const auto &status) { | ||
| log_->warn( | ||
| "Received already processed batch. Duplicate transaction: {}", |
There was a problem hiding this comment.
From the log it will be unclear, where messages about one batch end and another starts. I propose to add some splitters to the messages, so it would be:
Batch 1:
Received already processed batch. Duplicate transaction 395gjfr8g49
Received already processed batch. Duplicate transaction fc409mir43k
Batch 42:
Received already processed batch. Duplicate transaction fk4590owfje
Of course, the information can be extracted from tx hashes, but for usability it will be better, if it were understood from the first glance
| @@ -13,7 +13,7 @@ | |||
| #include <unordered_map> | |||
|
|
|||
| #include <tbb/concurrent_queue.h> | |||
|
|
|||
| #include "ametsuchi/tx_presence_cache.hpp" | |||
There was a problem hiding this comment.
Won't forward declaration here and include in .cpp work?
Signed-off-by: Nikita Alekseev <n.alekseev2104@gmail.com>
Signed-off-by: Nikita Alekseev <n.alekseev2104@gmail.com>
Akvinikym
approved these changes
Nov 16, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR adds replay prevention during proposal generation in on demand ordering service.
Benefits
Replay prevention
Possible Drawbacks
All batches must be checked via cache