Replay check to ordering gate #1868
Conversation
Signed-off-by: Nikita Alekseev <n.alekseev2104@gmail.com>
Signed-off-by: Nikita Alekseev <n.alekseev2104@gmail.com>
| @@ -19,27 +21,35 @@ using namespace framework::test_subscriber; | |||
|
|
|||
| using ::testing::_; | |||
| using ::testing::ByMove; | |||
| using testing::NiceMock; | |||
There was a problem hiding this comment.
please add :: for consistency
| return true; | ||
| }, | ||
| [](const auto &status) { | ||
| // TODO: log replayed transactions when log is added |
Signed-off-by: Nikita Alekseev <n.alekseev2104@gmail.com>
| std::unique_ptr<shared_model::interface::Proposal> | ||
| OnDemandOrderingGate::removeReplays( | ||
| const shared_model::interface::Proposal &proposal) const { | ||
| auto not_processed_txs = [this](const auto &tx) { |
There was a problem hiding this comment.
I suggest renaming this function to something like tx_is_not_processed, because a) it currently looks very similar to the variable below, unprocessed_txs, which is the result of applying this filter, and b) it handles single tx, so no "txs"
Signed-off-by: Nikita Alekseev <n.alekseev2104@gmail.com>
…feature/ordering_gate_replay_prevention
Signed-off-by: Nikita Alekseev <n.alekseev2104@gmail.com>
Signed-off-by: Nikita Alekseev <n.alekseev2104@gmail.com>
| @@ -41,14 +44,12 @@ OnDemandOrderingGate::OnDemandOrderingGate( | |||
| // request proposal for the current round | |||
| auto proposal = network_client_->onRequestProposal(current_round_); | |||
|
|
|||
| auto final_proposal = this->processProposalRequest(proposal); | |||
There was a problem hiding this comment.
Maybe use std::move(proposal) instead? Because proposal should not be used after processing it
| current_round_.block_round, current_round_.reject_round, {}); | ||
| } | ||
| if (not *proposal) { | ||
| return nullptr; |
There was a problem hiding this comment.
This branch will not execute, it is guaranteed by onRequestProposal interface. So it is better to remove it.
| const shared_model::interface::Proposal &proposal) const { | ||
| auto not_processed_txs = [this](const auto &tx) { | ||
| auto tx_result = tx_cache_->check(tx.hash()); | ||
| return iroha::visit_in_place( |
There was a problem hiding this comment.
Please check if it creates a visitor struct on each call. If it does, it is better to replace this construction with boost::get.
Signed-off-by: Nikita Alekseev <n.alekseev2104@gmail.com>
Signed-off-by: Nikita Alekseev n.alekseev2104@gmail.com
Description of the Change
This PR adds a replay check to ordering gate via transaction cache
Benefits
No replays in ordering gate
Possible Drawbacks
None