This repository has been archived by the owner on Apr 17, 2019. It is now read-only.
Renamed Client Services #1881
Merged
Renamed Client Services #1881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muratovv
previously requested changes
Nov 26, 2018
There was a problem hiding this comment.
I have some issues about this PR:
- There is no reason to rename PRPC services in the code now. We need to come up with changes in schema - proto files
- postfix 1_0 is misleading here because service will contain information only about the major version. I suggest using v1 postfix instead.
Signed-off-by: Akvinikym <anarant12@gmail.com>
Akvinikym
force-pushed
the
refactor/client-services-rename
branch
from
6f89294
to
455f4e1
Compare
kamilsa
approved these changes
Nov 27, 2018
nickaleks
approved these changes
Nov 27, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
To prepare Iroha for backward compatibility,
CommandServiceandQueryServiceshould be given version tags,1_0in this case.Benefits
One more step to BC.
Possible Drawbacks
Harder to read?