This repository has been archived by the owner on Apr 17, 2019. It is now read-only.
GetAccountTransactions Pagination #1903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nikita Alekseev <n.alekseev2104@gmail.com>
Signed-off-by: Nikita Alekseev <n.alekseev2104@gmail.com>
Signed-off-by: Nikita Alekseev <n.alekseev2104@gmail.com>
Signed-off-by: Nikita Alekseev <n.alekseev2104@gmail.com>
Signed-off-by: Nikita Alekseev <n.alekseev2104@gmail.com>
Signed-off-by: Nikita Alekseev <n.alekseev2104@gmail.com>
Signed-off-by: Nikita Alekseev <n.alekseev2104@gmail.com>
Signed-off-by: Nikita Alekseev <n.alekseev2104@gmail.com>
Signed-off-by: Nikita Alekseev <n.alekseev2104@gmail.com>
Signed-off-by: Nikita Alekseev <n.alekseev2104@gmail.com>
Signed-off-by: Nikita Alekseev <n.alekseev2104@gmail.com>
…rledger/iroha into feature/get_transactions_pagination
Signed-off-by: Nikita Alekseev <n.alekseev2104@gmail.com>
Signed-off-by: Nikita Alekseev <n.alekseev2104@gmail.com>
nickaleks
changed the title
Signed-off-by: Nikita Alekseev <n.alekseev2104@gmail.com>
nickaleks
force-pushed
the
feature/get_transactions_pagination
branch
from
b1b287a
to
81a1fd4
Compare
Signed-off-by: Nikita Alekseev <n.alekseev2104@gmail.com>
kamilsa
approved these changes
Dec 4, 2018
| @@ -606,9 +606,10 @@ CREATE TABLE IF NOT EXISTS account_has_grantable_permissions ( | |||
| + R"() NOT NULL, | |||
| PRIMARY KEY (permittee_account_id, account_id) | |||
| ); | |||
| CREATE TABLE IF NOT EXISTS height_by_hash ( | |||
There was a problem hiding this comment.
We still have that table in ametsuchi fixture. Replace it there as well
Akvinikym
previously requested changes
Dec 5, 2018
| using PermissionTuple = boost::tuple<int>; | ||
|
|
||
| auto cmd = (boost::format(R"(WITH has_perms AS (%s), | ||
| auto &pagination_info = q.paginationMeta(); |
There was a problem hiding this comment.
If paginationMeta() returns constref, it should be const auto &pagination_info
|
|
||
| return query_response_factory_->createTransactionsResponse( | ||
| std::move(response_txs), query_hash_); | ||
| // next transaction exists |
There was a problem hiding this comment.
Not very clear comment, please expand it a little
| framework::SpecifiedVisitor< | ||
| shared_model::interface::AccountResponse>(), | ||
| result->get()); | ||
| const auto &cast_resp = getRef<AccountResponse>(result->get()); |
There was a problem hiding this comment.
Please, cancel changes in existing tests, as there will be a significant amount of conflicts with this PR when merging
nickaleks
force-pushed
the
feature/get_transactions_pagination
branch
2 times, most recently
from
5dbe520
to
a14daa4
Compare
Signed-off-by: Nikita Alekseev <n.alekseev2104@gmail.com>
nickaleks
force-pushed
the
feature/get_transactions_pagination
branch
from
a14daa4
to
1f17fdd
Compare
Akvinikym
approved these changes
Dec 5, 2018
…rledger/iroha into feature/get_transactions_pagination
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR introduces pagination logic to get account transactions query.
You can now specify starting hash and page size of the response.
Benefits
Pagination
Possible Drawbacks
Slower queries due to added complexity
Alternate Designs [optional]
In several places, additional indexes can be introduced in the future to optimize query