This repository has been archived by the owner on Apr 17, 2019. It is now read-only.
Proto Validation for Block #1905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Akvinikym <anarant12@gmail.com>
nickaleks
previously requested changes
Dec 4, 2018
|
|
||
| namespace shared_model { | ||
| namespace validation { | ||
| class ProtoBlockValidator |
There was a problem hiding this comment.
Please split into cpp and hpp
Signed-off-by: Akvinikym <anarant12@gmail.com>
Signed-off-by: Akvinikym <anarant12@gmail.com>
nickaleks
approved these changes
Dec 4, 2018
kamilsa
approved these changes
Dec 4, 2018
kamilsa
pushed a commit
that referenced
this pull request
Dec 12, 2018
* Proto Validator is added Signed-off-by: Akvinikym <anarant12@gmail.com> * Review issues Signed-off-by: Akvinikym <anarant12@gmail.com> * Review issues 2 Signed-off-by: Akvinikym <anarant12@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
After one_of version field was added to Block, it started needing a protocol validation, which would check, if this field is set.
Benefits
Ill-formed Blocks are not allowed
Possible Drawbacks
None.
Usage Examples or Tests [optional]
proto_block_validator_testwas added.