This repository has been archived by the owner on Apr 17, 2019. It is now read-only.
Hash-based round-robin OS integration #1923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kitsu <mail@kitsu.me>
Signed-off-by: Kitsu <mail@kitsu.me>
- Rework Synchronizer in BFT compatible manner - Extende SyncEvent with height and kNothing outcome - Update synchronizer tests - Fixed accordingly GateObjects (Rejects & Agreement on None) Signed-off-by: Kitsu <mail@kitsu.me>
Signed-off-by: Kitsu <mail@kitsu.me>
* Refactor yac gate test with subject * Add test case for VoteOther * Fix VoteOther struct and handling Signed-off-by: Andrei Lebedev <lebdron@gmail.com>
* Integrate on-demand OS with fixes * Fix round number on commit * Comment out integration tests and fix gate test * Use hashes from storage if present Signed-off-by: Andrei Lebedev <lebdron@gmail.com>
Signed-off-by: Andrei Lebedev <lebdron@gmail.com>
* Refactor ordering gate observable to optional * Rename observables Signed-off-by: Andrei Lebedev <lebdron@gmail.com>
* Refactor verified proposal creator to optional * Refactor block creator to optional Signed-off-by: Andrei Lebedev <lebdron@gmail.com>
Signed-off-by: Andrei Lebedev <lebdron@gmail.com>
Signed-off-by: Andrei Lebedev <lebdron@gmail.com>
* OnDemandOrderingInit peer selector verbose logging * OnDemandOrderingServiceImpl::onRequestProposal log whether returned a proposal * OnDemandOrderingServiceImpl::onBatches logging Signed-off-by: Mikhail Boldyrev <miboldyrev@gmail.com>
Signed-off-by: Andrei Lebedev <lebdron@gmail.com>
Signed-off-by: Andrei Lebedev <lebdron@gmail.com>
muratovv
approved these changes
Dec 11, 2018
* Fix uncommitted cache Signed-off-by: kamilsa <kamilsa16@gmail.com>
Signed-off-by: kamilsa <kamilsa16@gmail.com>
Signed-off-by: Andrei Lebedev <lebdron@gmail.com>
kamilsa
approved these changes
Dec 11, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Introduce hash-based round robin selection of ordering services for consensus rounds.
Benefits
Network progresses when the first ordering service is down, compared to previous implementation.
Possible Drawbacks
Yet to discover.