This repository has been archived by the owner on Apr 17, 2019. It is now read-only.
Fix memory leaks on irohad shutdown #1968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Konstantin Munichev <toobwn@gmail.com>
l4l
added
needs-review
|
How did you test, that the listed subscriptions leaks memory? I'm not really sure, but though that |
|
I built irohad target with leak sanitizer, than run and stop it. It clearly showed leaks without unsubscribe. |
Akvinikym
approved these changes
Dec 21, 2018
lebdron
approved these changes
Dec 21, 2018
There was a problem hiding this comment.
We decided to reorder fields in irohad in another pull request. The following destructor should be removed in the next pull request.
https://github.com/hyperledger/iroha/blob/03c5b1da2ccc8cb7e67909b2fb5b35f3fbfabb83/irohad/main/application.cpp#L516-L520
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Pull request fixes couple of memory leaks on irohad shutdown by calling unsubscribe() in destructors of several classes.
Benefits
Clean output of leak sanitizer, Irohad destructor is called now.
Possible Drawbacks
None.