This repository has been archived by the owner on Apr 17, 2019. It is now read-only.
Round-based status stream break-off #1980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Akvinikym <anarant12@gmail.com>
Signed-off-by: Akvinikym <anarant12@gmail.com>
Signed-off-by: Akvinikym <anarant12@gmail.com>
Signed-off-by: Akvinikym <anarant12@gmail.com>
|
Cool PR name :) |
l4l
reviewed
Dec 21, 2018
libs/common/subscription_watcher.hpp
Outdated
| std::lock_guard<std::mutex> lock{this->mutex_}; | ||
| auto it = subscriptions_.begin(); | ||
| while (it != subscriptions_.end()) { | ||
| if (++it->second.counter >= kMaxCounterValue) { |
There was a problem hiding this comment.
that will perform increment, even if the condition isn't true. That might have some undesirable edge-case issues, e.g if kMaxCounterValue == UINT8_MAX
Signed-off-by: Akvinikym <anarant12@gmail.com>
nickaleks
approved these changes
Dec 25, 2018
|
|
||
| std::mutex round_update_mutex_; | ||
| std::shared_ptr<iroha::network::ConsensusGate> consensus_gate_; | ||
| const int kMaximumRoundsWithoutUpdate; |
There was a problem hiding this comment.
It's a constant since you set it in a constructor, so usual naming should be used here.
| round_notifier.get_subscriber().on_next(iroha::consensus::BlockReject{}); | ||
|
|
||
| // if this join happens, this means that stream is off | ||
| t.join(); |
There was a problem hiding this comment.
This test will never terminate if the code it tests is broken. Please add a timeout, after which the test has failed.
kamilsa
approved these changes
Dec 25, 2018
Signed-off-by: Akvinikym <anarant12@gmail.com>
Signed-off-by: Akvinikym <anarant12@gmail.com>
Signed-off-by: Akvinikym <anarant12@gmail.com>
Signed-off-by: Akvinikym <anarant12@gmail.com>
Signed-off-by: Akvinikym <anarant12@gmail.com>
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IR-130
Description of the Change
Previously, if status of the transaction was not updated for some time, status stream, on which client was subscribed, went off. This is a correct behaviour, but instead of waiting for time, Iroha should wait for some rounds to complete, and this is what this PR does.
Benefits
More correct behaviour.
Possible Drawbacks
None.