This repository has been archived by the owner on Jul 20, 2022. It is now read-only.
Fix lint and clippy issues caused by new rust update #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrea Gunderson <agunde@bitwise.io>
agunde406
requested review from
aludvik,
dplumb94,
grkvlt,
knkski,
peterschwarz and
vaporos
as code owners
agunde406
force-pushed
the
agunde406-fix-lint
branch
from
c6364b1
to
7c69973
Compare
This was raised by clippy. Simply removing the ? fixed the issue. Signed-off-by: Andrea Gunderson <agunde@bitwise.io>
Signed-off-by: Andrea Gunderson <agunde@bitwise.io>
Signed-off-by: Andrea Gunderson <agunde@bitwise.io>
Signed-off-by: Andrea Gunderson <agunde@bitwise.io>
Signed-off-by: Andrea Gunderson <agunde@bitwise.io>
agunde406
force-pushed
the
agunde406-fix-lint
branch
from
7c69973
to
1fd15ab
Compare
dplumb94
approved these changes
Sep 30, 2019
vaporos
approved these changes
Oct 1, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds linting and clippy checks for seth rpc