This repository has been archived by the owner on Jul 20, 2022. It is now read-only.
Change default RPC return values #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knkski
force-pushed
the
fixing-default-nonce
branch
from
54a6d9c
to
3c22255
Compare
knkski
changed the title
rberg2
requested review from
grkvlt,
peterschwarz,
vaporos,
aludvik and
dplumb94
knkski
force-pushed
the
fixing-default-nonce
branch
5 times, most recently
from
b496736
to
9acc51d
Compare
The transaction count and balance should be 0 for non-existent accounts, not null. Additionally, the code and contract address fields should be blank. Signed-off-by: Kenneth Koski <knkski@bitwise.io>
knkski
force-pushed
the
fixing-default-nonce
branch
from
9acc51d
to
ae1331c
Compare
aludvik
approved these changes
Aug 13, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The transaction count and balance should be 0 for non-existent accounts, not null. Additionally, the code should be blank.
See https://github.com/ethereum/go-ethereum/blob/d926bf2c7e3182d694c15829a37a0ca7331cd03c/core/state/statedb.go#L199 for prior art.
Signed-off-by: Kenneth Koski knkski@bitwise.io