Skip to content
This repository has been archived by the owner on Jul 20, 2022. It is now read-only.

Remove RPC FilterManager mutability #65

Merged
merged 2 commits into from
Sep 4, 2018

Conversation

knkski
Copy link
Contributor

@knkski knkski commented Aug 28, 2018

Because the FilterManager manages itself with interior mutability, references to FilterManager don't need to be mut. This PR removes the unnecessary mutability.

Because the FilterManager manages itself with interior mutability,
references to FilterManager don't need to be `mut`. This PR removes the
unnecessary mutability.

Signed-off-by: Kenneth Koski <knkski@bitwise.io>
@knkski knkski self-assigned this Aug 28, 2018
@knkski knkski changed the title Filtering mutability Remove RPC FilterManager mutability Aug 28, 2018
@dplumb94
Copy link
Contributor

dplumb94 commented Aug 28, 2018

Got an error on build:

error: unknown start of token: `
   --> src/client.rs:225:95
    |
225 |     pub fn send_request<T, U>(&mut self, msg_type: Message_MessageType, msg: &T) -> Result<U, `>
    |                                                                                               ^
help: Unicode character '`' (Grave Accent) looks like ''' (Single Quote), but it is not
    |
225 |     pub fn send_request<T, U>(&mut self, msg_type: Message_MessageType, msg: &T) -> Result<U, '>
    |                                                                                               ^

error: aborting due to previous error

error: Could not compile `rpc`.

To learn more, run the command again with --verbose.

Not sure if that is part of your PR or not

@knkski
Copy link
Contributor Author

knkski commented Aug 29, 2018

@dplumb94: I don't think that's due to this PR, since that's coming from a file that's unaffected by this PR. Can you try doing git reset --hard HEAD on this branch and seeing if that fixes it?

The RPC tests failed to run. This PR fixes them and adds them to the
`bin/run_tests` command to prevent bitrot.

Signed-off-by: Kenneth Koski <knkski@bitwise.io>
@knkski knkski merged commit 8ffc653 into hyperledger-archives:master Sep 4, 2018
@knkski knkski deleted the filtering-mutability branch September 4, 2018 21:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants