This repository has been archived by the owner on Jul 20, 2022. It is now read-only.
Remove mut requirement on ValidatorClient #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The zmq library we use for sending messages doesn't actually require a mutable reference for sending and replying. This PR changes the `&mut self` references to just `&self`. Relies on hyperledger-archives/sawtooth-core#1834 being merged. Signed-off-by: Kenneth Koski <knkski@bitwise.io>
knkski
requested review from
grkvlt,
peterschwarz,
vaporos,
aludvik and
dplumb94
vaporos
approved these changes
Aug 29, 2018
dplumb94
approved these changes
Aug 31, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The zmq library we use for sending messages doesn't actually require a mutable reference for sending and replying. This PR changes the
&mut selfreferences to just&self.Relies on hyperledger-archives/sawtooth-core#1834 being merged.
Signed-off-by: Kenneth Koski knkski@bitwise.io