Skip to content
This repository has been archived by the owner on Jul 20, 2022. It is now read-only.

Updated docker-compose.yaml to fix rpc bug #99

Closed
wants to merge 3 commits into from

Conversation

Mansoor-AR
Copy link

In order to unlock accounts with Seth-rpc, the rpc service and the cli-go service need to share a volume where the aliases are stored. This PR introduces that volume.

@peterschwarz
Copy link
Contributor

I think you are missing the sign-offs in your commit message. You can fix it by running

$ git commit -s --amend

While you are there, please add some more context to your commit message, following this guide for writing commit messages: https://chris.beams.io/posts/git-commit/

After you've done this, force push your branch.

@vaporos
Copy link
Contributor

vaporos commented Jun 4, 2019

Can you add more context to the commit message itself? "In order to unlock accounts with Seth-rpc, the rpc service and the cli-go service need to share a volume where the aliases are stored. This PR introduces that volume." would work.

Copy link
Contributor

@grkvlt grkvlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vaporos
Copy link
Contributor

vaporos commented Mar 17, 2021

This PR cannot be merged because the commit doesn't pass the DCO check (see comment from Apr 25, 2019) and we have a request to update the commit message (see comment from Jan 4, 2019). AFAIK these are the only things holding up this PR.

Mansoor-AR and others added 2 commits March 20, 2021 12:23
Signed-off-by: Mansoor Ahmed-Rengers <mansoor.ahmed@cl.cam.ac.uk>
@arsulegai
Copy link
Contributor

@Mansoor-AR I see 3 commits in place of one for this change. One option could be to cherry-pick the commit with DCO and then force push to the same branch name.

@rbuysse
Copy link
Contributor

rbuysse commented Jul 19, 2022

This repository will be archived soon so I'm closing this PR. Thanks for your contribution!

@rbuysse rbuysse closed this Jul 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants