get utility emissions channel automated tests working

[sichen1234]

The automated tests in utility-emissions-channel/typescript_app/runTests.sh is not working. Get the tests to work and be able to verify the record emissions and get emissions.

[sichen1234]

Currently the tests are described in https://github.com/hyperledger-labs/blockchain-carbon-accounting/tree/main/utility-emissions-channel#automated-tests. We need to get them working again.

[unnati914]

I am Unnati, a prefinal year student from India. I am applying for LFX Fall Mentorship Program this time. I saw the project and found the project interesting. The project really aligns my tech stack. So how should I proceed with this? Like should I make a proposal or is there any task to be done before the deadline?

Please let me know the further steps so that I could submit the application before the deadline

[udosson]

@unnati914, thanks for your comment. Let's take about the application process for the mentorship program via email. I've already answered your email.
If you already want to contribute to our lab prior to the official start of the mentorship programs we'd really appreciate this.
Just let us know if there is any issue you want to start working on. Then, we'll assign it to you.

[unnati914]

sure I am just understanding the code.. then I will take one good first issue

[unnati914]

I am getting errors while installing docker on windows.. could you please help me

[udosson]

Yes, I can support you. Please, use https://chat.hyperledger.org/channel/climate-action-sig for general communication that is not directly related to the issues. I'll give some advice in the Hyperledger rocket cat

[skant7]

hi @udosson I ran the tests on my local machine it seems that 3 tests pass and remaining 3 of them fail can you please check if its the same error or am I missing out on anything?
Here's a screenshot of the tests:-

[hs2361]

Hi, @sichen1234. In commit 739178f by @Zzocker , end-to-end testing was added which seems to account for all the cases that are covered by the automated tests in the test.js file. The tests can be run by running npm run test, and it appears that all 7 tests are passing. In that case, do we still need to retain the old tests, since the E2E tests cover the same tests? Please let me know so that I can proceed with the issue accordingly.

[Zzocker]

e2e test covers all the test cases of test.js along with 3 to 4 more test which checks some more corner cases. Also for running e2e test you won't have to put data by running the scripts form docker-setup folder. By running e2e test one mock emission record is inserted into the fabric.

[hs2361]

@Zzocker Do you think we can remove the test.js file entirely since the E2E tests are a superset of those tests? Please also take a look at the test case required by #190. If even that case is covered, @sichen1234 I think we can simply remove the file and close this issue, as well as #190.

[Zzocker]

Yes, it covers #190
here :

blockchain-carbon-accounting/utility-emissions-channel/typescript_app/tests/e2e.test.ts

Lines 197 to 198 in 2a8e15f

	assert.equal(response.body.fromDate, '2020-05-07T10:10:09Z');
	assert.equal(response.body.thruDate, '2021-05-07T10:10:09Z');

Also can you add a try/catch block here :

blockchain-carbon-accounting/utility-emissions-channel/typescript_app/tests/e2e.test.ts

Lines 71 to 78 in 2a8e15f

	assert.isNull(error);
	assert.equal(response.status, 201);
	assert.equal(response.body.orgName, 'auditor1');
	assert.equal(response.body.msp, 'auditor1');
	assert.equal(response.body.caName, 'auditor1.carbonAccounting.com');
	await insertMockData(registry);
	done();

This is required, cuz if registerAdmin should pass fails, then the whole test will be stuck there.

[hs2361]

@sichen1234 Do you suggest that we close this issue, and then open a fresh issue for the changes suggested by @Zzocker?

[udosson]

@hs2361, yes you can close this issue and create a new issue with the changes suggested by @Zzocker. Thanks!