Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: disable enableAuthentication auth auto login using wrong network key issue #250

Merged
merged 2 commits into from Jun 18, 2021
Merged

Bugfix: disable enableAuthentication auth auto login using wrong network key issue #250

merged 2 commits into from Jun 18, 2021

Conversation

ThomasRalee
Copy link
Contributor

@ThomasRalee ThomasRalee commented Jun 16, 2021 •
edited

This PR:

  • resolves enableAuthentication:false setup using wrong network key preventing auto login issue.

Screenshot:

image

@ThomasRalee
Bugfix: disable auth auto login using wrong network key
8e8fd83 
Signed-off-by: Thomas <thomas.leera@gmail.com>
nekia
nekia suggested changes Jun 17, 2021
View reviewed changes
Copy link
Contributor

@nekia nekia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really appreciate to your contribution. Yes, this is a bug when disabling authentication. We should fix it to id. Thanks.
image

JeevaSang
JeevaSang approved these changes Jun 17, 2021
View reviewed changes
Copy link
Contributor

@JeevaSang JeevaSang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@ThomasRalee ThomasRalee requested a review from nekia June 18, 2021 07:28
@ThomasRalee
Update PR base on nekia review
38c3267 
Signed-off-by: Thomas <thomas.leera@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Jun 18, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

nekia
nekia approved these changes Jun 18, 2021
View reviewed changes
Copy link
Contributor

@nekia nekia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@nekia nekia merged commit 4a931ca into hyperledger-labs:main Jun 18, 2021
@ThomasRalee ThomasRalee deleted the bugfix/disable-auth-login-using-wrong-network-key branch June 27, 2021 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nekia nekia nekia approved these changes

@JeevaSang JeevaSang JeevaSang approved these changes

@nfrunza nfrunza Awaiting requested review from nfrunza

@vchinoy-da vchinoy-da Awaiting requested review from vchinoy-da

@xspeedcruiser xspeedcruiser Awaiting requested review from xspeedcruiser

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ThomasRalee @nekia @JeevaSang