Add validations to search functionality blockId and blockRange #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (startBlockNo < endBlockNo) { | ||
| if ( | ||
| startBlockNo <= endBlockNo && | ||
| startBlockNo >= 0 && |
There was a problem hiding this comment.
Q: please confirm if start block can be zero.
There was a problem hiding this comment.
startBlockNo can be Zero.
|
ArchanaArige
force-pushed
the
BE375-AddValidations
branch
2 times, most recently
from
5fcd2b5
to
735b314
Compare
|
removed the "blockRangeLimit" from config.json file. The blockRangeLimit value is now managed from UI itself. |
Signed-off-by: ArchanaArige <nigam_archana@yahoo.co.in>
ArchanaArige
force-pushed
the
BE375-AddValidations
branch
from
b4a8fda
to
da930cf
Compare
adityajoshi12
approved these changes
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
By adding validations, the code can handle the issues arising due to incorrect channelgenesishash etc. A user can also configure the "blockRangeLimit" in the config.json file. A backend configurable "blockRangeLimit" value can harness the user, with more flexibility of setting the blockRange value.
Which issue(s) this PR fixes:
Fixes #375
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation, usage docs, etc.: