Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated docker compse files with ghcr images #438

Merged
merged 1 commit into from Sep 4, 2023

Conversation

vineeth2328
Copy link
Member

What this PR does / why we need it:

Change the image location in docker-compose pointing to GHCR . Earlier the images were stored in docker-hub. From now on the images would be stored in GHCR. To suffice this requirement, need to update the docker-compose.

Which issue(s) this PR fixes:

Fixes #435

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NO

Additional documentation, usage docs, etc.:


@ArchanaArige
Copy link
Contributor

Looks fine. Let @arsulegai , @adityajoshi12 also review.

@adityajoshi12
Copy link
Contributor

Let's wait for the #382 to get merged.

Copy link
Member

@arsulegai arsulegai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArchanaArige
Copy link
Contributor

LGTM. Could you please update other files as well? https://github.com/search?q=repo%3Ahyperledger-labs%2Fblockchain-explorer%20hyperledger%2Fexplorer&type=code

The ReadMe related changes w.r.t images are quoted in Release PR. It's not yet merged. There are other changes also that needs to be incorporated like new commits to be added in changelog.md, etc. Once all the PRS are merged, finally will merge the Release PR.

@arsulegai
Copy link
Member

LGTM. Could you please update other files as well? https://github.com/search?q=repo%3Ahyperledger-labs%2Fblockchain-explorer%20hyperledger%2Fexplorer&type=code

The ReadMe related changes w.r.t images are quoted in Release PR. It's not yet merged. There are other changes also that needs to be incorporated like new commits to be added in changelog.md, etc. Once all the PRS are merged, finally will merge the Release PR.

Thank you

Signed-off-by: vineeth2328 <vineethboppudi23@gmail.com>
@arsulegai arsulegai merged commit ea53e73 into hyperledger-labs:main Sep 4, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update docker-compose with image pointing to GHCR
4 participants