Skip to content
This repository has been archived by the owner on Apr 13, 2022. It is now read-only.

Empty object should be handled before passing to JSON.parse #81

Open
Vishwas1 opened this issue Apr 12, 2019 · 1 comment
Open

Empty object should be handled before passing to JSON.parse #81

Vishwas1 opened this issue Apr 12, 2019 · 1 comment

Comments

@Vishwas1
Copy link

The problem

in this line empty object should be handled before passing to JSON.parse... check it out
const result = JSON.parse(txResult.result.response.payload.toString('utf8'));

https://github.com/hyperledger-labs/convector/blob/develop/%40worldsibu/convector-common-fabric-helper/src/client.helper.ts#L198

Environment

  • Convector version (or git revision) that exhibits the issue:
  • Last Convector version that did not exhibit the issue (if applicable):
  • OS/version:
  • Node.js version:
  • Npm or Yarn package manager:
  • Convector CLI version (if applicable):
  • Hurley CLI version (if applicable):

Details

Current Behavior

Explain what the current behavior is

Expected Behavior

Explain what you were expecting to happend instead

Code To Reproduce Issue [ Good To Have ]

Please remember that with sample code it's easier to reproduce the bug and it's much faster to fix it.

Use convector-cli if possible as the base to reproduce the issue

@diestrin
Copy link
Contributor

Hey @Vishwas1, thanks for the issue. Can you please provide an example of how to reproduce your issue? Or explain a little bit more in detail what the problem is?
Thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants