Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifiers #570

Merged
merged 2 commits into from
May 23, 2024
Merged

Notifiers #570

merged 2 commits into from
May 23, 2024

Conversation

alexandrosfilios
Copy link
Contributor

@alexandrosfilios alexandrosfilios commented May 10, 2024

This PR introduces the notifiers that allow us to listen for any row insert/update/delete in the DB.
The new functionality is in the two files notifier.go. The rest is moving files to allow for deduplication of logic between the Postgres and the sqlite implementation.

@alexandrosfilios alexandrosfilios changed the base branch from main to cache-fix May 10, 2024 13:13
@alexandrosfilios alexandrosfilios marked this pull request as ready for review May 10, 2024 13:15
@alexandrosfilios alexandrosfilios changed the base branch from cache-fix to main May 23, 2024 06:40
@alexandrosfilios alexandrosfilios force-pushed the notifiers branch 2 times, most recently from 7373a6c to ee42292 Compare May 23, 2024 06:55
@alexandrosfilios alexandrosfilios changed the base branch from main to cache-fix May 23, 2024 06:56
@alexandrosfilios alexandrosfilios force-pushed the cache-fix branch 3 times, most recently from 24c0a83 to b8b750b Compare May 23, 2024 10:42
Copy link
Contributor

@adecaro adecaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Alexandros Filios <alexandros.filios@ibm.com>
Signed-off-by: Alexandros Filios <alexandros.filios@ibm.com>
@alexandrosfilios alexandrosfilios merged commit ac0ff4f into main May 23, 2024
4 checks passed
@alexandrosfilios alexandrosfilios deleted the notifiers branch May 23, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants