Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove default resolver, register the node id itself so we don't need… #573

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

arner
Copy link
Contributor

@arner arner commented May 17, 2024

… the alias.

This PR attempts to solve two things:

  1. The default resolver, which was registered with the node id and the grpc address, was causing unpredictable behaviour with the new websockets communication method (the default resolver is selected instead of the correct one - even though the grpc address is empty).
  2. It was necessary to list the resolver id as 'alias' in the configuration, even though it's not really an alias if it's the same id. The code in this PR binds the node id to itself, so it's not necessary anymore to do that.

For the first one, I'm not sure if this code was still in use in some way. For the second, binding the id to itself looks a bit odd, and there might be cleaner solutions available that I'm not aware of. Would like to get some feedback before 'undrafting' it.

… the alias

Signed-off-by: Arne Rutjes <arne123@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant