improve logs #611
Merged
improve logs #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adecaro
approved these changes
Jul 3, 2024
platform/fabric/sdk/dig/sdk.go
Outdated
| @@ -190,17 +190,17 @@ func registerRWSetLoaderHandlerProviders(in struct { | |||
| for _, network := range in.CoreConfig.Names() { | |||
| fsn, err := in.FSNProvider.FabricNetworkService(network) | |||
| if err != nil { | |||
| return fmt.Errorf("could not find network service for %s", network) | |||
| return fmt.Errorf("could not find network service for %s: %w", network, err) | |||
There was a problem hiding this comment.
Please, Arne, given that you are changing this, could replace fmt with the package github.com/hyperledger-labs/fabric-smart-client/pkg/utils/errors. Thanks.
| @@ -25,7 +25,7 @@ const sqlitePragmas = ` | |||
|
|
|||
| const driverName = "sqlite" | |||
|
|
|||
| var logger = flogging.MustGetLogger("postgres-db") | |||
| var logger = flogging.MustGetLogger("sqlite-db") | |||
There was a problem hiding this comment.
Please, can you add the prefix view-sdk.db.<the rest>, so we can catch it more easily when setting the logs level.
Signed-off-by: Arne Rutjes <arne123@gmail.com>
Signed-off-by: Arne Rutjes <arne123@gmail.com>
Signed-off-by: Arne Rutjes <arne123@gmail.com>
Signed-off-by: Arne Rutjes <arne123@gmail.com>
Signed-off-by: Arne Rutjes <arne123@gmail.com>
Signed-off-by: Arne Rutjes <arne123@gmail.com>
Signed-off-by: Arne Rutjes <arne123@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.