Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fabric commit processor doesn't handle anymore tokens #619

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

adecaro
Copy link
Contributor

@adecaro adecaro commented Apr 29, 2024

This job is left to the audit and transaction dbs.

@@ -65,7 +62,7 @@ func (r *RWSetProcessor) Process(req fabric.Request, tx fabric.ProcessTransactio
case "init":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can add a comment to explain why init stays (because we don't know the txid of the chain code-upgrade tx's) and why default returns nil (because it's processed by the filter)

Copy link
Contributor

@alexandrosfilios alexandrosfilios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo comment

Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
@adecaro adecaro merged commit 2e2fb32 into main Apr 30, 2024
38 checks passed
@adecaro adecaro deleted the f-fabric-processor branch April 30, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants