Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor integration tests and add web socket integration tests #651

Merged
merged 3 commits into from
Jun 5, 2024
Merged

Refactor integration tests and add web socket integration tests #651

merged 3 commits into from
Jun 5, 2024

Conversation

alexandrosfilios
Copy link
Contributor

@alexandrosfilios alexandrosfilios commented Jun 5, 2024 •
edited
Loading

  • Split the tests into more parts
  • Added web socket integration tests
  • Extracted common code from integration tests to avoid duplication
  • Added selectors to distinguish when we need the ID and when the name of a node

@alexandrosfilios
Refactored integration tests to accept postgres and replicas as a param
4f0e344 
Signed-off-by: Alexandros Filios <alexandros.filios@ibm.com>
@alexandrosfilios
Added ID selector
f97e440 
Signed-off-by: Alexandros Filios <alexandros.filios@ibm.com>
@alexandrosfilios
Refactored tests and introduced test types to avoid repetition
ed8142f 
Signed-off-by: Alexandros Filios <alexandros.filios@ibm.com>
adecaro
adecaro approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@adecaro adecaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo the comments that can be addressed in another PR too.

integration/nwo/token/options.go Outdated Show resolved Hide resolved
@alexandrosfilios alexandrosfilios merged commit f57107b into main Jun 5, 2024
45 checks passed
@alexandrosfilios alexandrosfilios deleted the refactor-integration-tests branch June 5, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adecaro adecaro adecaro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexandrosfilios @adecaro