DIG for tokensdk #656
Merged
DIG for tokensdk #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandros Filios <alexandros.filios@ibm.com>
Signed-off-by: Alexandros Filios <alexandros.filios@ibm.com>
Signed-off-by: Alexandros Filios <alexandros.filios@ibm.com>
Signed-off-by: Alexandros Filios <alexandros.filios@ibm.com>
adecaro
requested changes
Jun 14, 2024
token/dig/sdk.go
Outdated
| "github.com/hyperledger-labs/fabric-token-sdk/token" | ||
| core2 "github.com/hyperledger-labs/fabric-token-sdk/token/core" | ||
| "github.com/hyperledger-labs/fabric-token-sdk/token/core/common/logging" | ||
| _ "github.com/hyperledger-labs/fabric-token-sdk/token/core/fabtoken/driver" |
There was a problem hiding this comment.
the other sdk.go doesn't have any blind imports. Why do we need them here?
There was a problem hiding this comment.
Oh no we don't need them. This version was based on a previous version of the sdk that had the blind imports. Will remove them.
token/dig/sdk.go
Outdated
| SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
|
|
||
| package sdk |
There was a problem hiding this comment.
can we move this package under sdk?
Signed-off-by: Alexandros Filios <alexandros.filios@ibm.com>
Signed-off-by: Alexandros Filios <alexandros.filios@ibm.com>
Signed-off-by: Alexandros Filios <alexandros.filios@ibm.com>
Signed-off-by: Alexandros Filios <alexandros.filios@ibm.com>
Signed-off-by: Alexandros Filios <alexandros.filios@ibm.com>
Signed-off-by: Alexandros Filios <alexandros.filios@ibm.com>
Signed-off-by: Alexandros Filios <alexandros.filios@ibm.com>
Signed-off-by: Alexandros Filios <alexandros.filios@ibm.com>
Signed-off-by: Alexandros Filios <alexandros.filios@ibm.com>
Signed-off-by: Alexandros Filios <alexandros.filios@ibm.com>
Signed-off-by: Alexandros Filios <alexandros.filios@ibm.com>
Signed-off-by: Alexandros Filios <alexandros.filios@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.