Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for peer hostAliases in create and update #120

Merged
merged 12 commits into from
Sep 24, 2022
Merged

Support for peer hostAliases in create and update #120

merged 12 commits into from
Sep 24, 2022

Conversation

minollo
Copy link
Contributor

@minollo minollo commented Sep 21, 2022

  • Let users specify host aliases, so that /etc/hosts on peer containers can be easily managed. Peers need to be able to resolve the ordering node names - needed when using Istio and no real DNS.
  • Introduce peer update command - for now to let users change host aliases even after the peer has been created.

@adityajoshi12
Copy link
Contributor

Q: updating the /etc/hosts file is not a good way, let's think of a better way to enable communication between peers and orderer, Kubernetes services could be one of the ways.

@minollo
Copy link
Contributor Author

minollo commented Sep 23, 2022

Surely not something you would want to use in production systems; but it is something which makes testing/prototyping with k8s/istio clusters where nodes are private easy.
Using k8s hostAliases - as I did here - it abstracts users from what happens (/etc/hosts) under the cover.

@dviejokfs
Copy link
Contributor

Thanks for the PR!
Could you implement the same for the orderer nodes?

Also, please, you need to complete the DCO; you can execute the following commands to resolve it:

git rebase --signoff HEAD~10
git push --force

dviejokfs and others added 10 commits September 23, 2022 21:20
@dviejokfs
fix helm chart deployment template (hyperledger#94)
83dd991 
Signed-off-by: dviejokfs <dviejo@kungfusoftware.es>
Signed-off-by: Minollo <carlo.innocenti@oracle.com>
@Wojciechowski-Marcin
Use user defined peer capacity (hyperledger#99)
12cff7c 
* Updated kubectl hlf plugin commands help

Signed-off-by: Wojciechowski Marcin <wojc.marcin@gmail.com>

* Use custom peer capacity

Signed-off-by: Wojciechowski Marcin <marcin.wojciechowski@espeo.eu>

Co-authored-by: Wojciechowski Marcin <marcin.wojciechowski@espeo.eu>
Signed-off-by: Minollo <carlo.innocenti@oracle.com>
@dviejokfs
1.7.0 release (hyperledger#95)
accceb9 
* Update README.md (hyperledger#92)

Signed-off-by: dviejokfs <84456338+dviejokfs@users.noreply.github.com>
Signed-off-by: dviejokfs <dviejo@kungfusoftware.es>

* - implement hyperledger#86 docs
- Filter by orderers hyperledger#93

Signed-off-by: dviejokfs <dviejo@kungfusoftware.es>

* image pull secrets optional to fix tests

Signed-off-by: dviejokfs <dviejo@kungfusoftware.es>

* Update manifests

Signed-off-by: dviejokfs <dviejo@kungfusoftware.es>

* update on push tags

Signed-off-by: dviejokfs <dviejo@kungfusoftware.es>

* create goreleaser beta for beta releases

Signed-off-by: dviejokfs <dviejo@kungfusoftware.es>

* Add fabric-operations-console

Signed-off-by: dviejokfs <dviejo@kungfusoftware.es>

* Fix error when inspect

Signed-off-by: dviejokfs <dviejo@kungfusoftware.es>

* Add hlf-operator-ui as a CRD

Add GRPCProxy to peer to oderer

Signed-off-by: dviejokfs <dviejo@kungfusoftware.es>

* Add CRD for console & UI

Signed-off-by: dviejokfs <dviejo@kungfusoftware.es>

* update types

Signed-off-by: dviejokfs <dviejo@kungfusoftware.es>

* add client for operation console and ui

Signed-off-by: dviejokfs <dviejo@kungfusoftware.es>

* Add HLF Operator UI

Signed-off-by: dviejokfs <dviejo@kungfusoftware.es>

* Add missing CRD

Signed-off-by: dviejokfs <dviejo@kungfusoftware.es>

* add operator api client

Signed-off-by: dviejokfs <dviejo@kungfusoftware.es>

* Issue hyperledger#100 - Add k8s-builder when kubernetes builder is set in peer
Issue hyperledger#96  - Batch size limit parametrization when creating channel
Issue hyperledger#86  - Configure image and version of peer CLI

Signed-off-by: dviejokfs <dviejo@kungfusoftware.es>

* add filenames docs needed for 1.7.0 release

Signed-off-by: dviejokfs <dviejo@kungfusoftware.es>

* Add TLSSecretName to operatorAPI and operations console

Signed-off-by: dviejokfs <dviejo@kungfusoftware.es>

* Adding peers docs

Signed-off-by: dviejokfs <dviejo@kungfusoftware.es>

* export orderer + docs + fix grpc web for orderer

Signed-off-by: dviejokfs <dviejo@kungfusoftware.es>

* Ignore windows arm64

Signed-off-by: dviejokfs <dviejo@kungfusoftware.es>

* Add export organization

Signed-off-by: dviejokfs <dviejo@kungfusoftware.es>

* Docs + config.json change

Signed-off-by: dviejokfs <dviejo@kungfusoftware.es>

* arch_chaincode_dev.png

Signed-off-by: dviejokfs <dviejo@kungfusoftware.es>

* Update docs

Signed-off-by: dviejokfs <dviejo@kungfusoftware.es>

* Update docs

Signed-off-by: dviejokfs <dviejo@kungfusoftware.es>

* Update docs

Signed-off-by: dviejokfs <dviejo@kungfusoftware.es>

* Implements hyperledger#101 to allow custom attributes

Signed-off-by: dviejokfs <dviejo@kungfusoftware.es>

* Allow to specify the cahost and caport when creating peer and orderer

Signed-off-by: dviejokfs <dviejo@kungfusoftware.es>

* Fix CLI issues

Signed-off-by: dviejokfs <dviejo@kungfusoftware.es>

* Add networkConfig to hlf operator

Signed-off-by: dviejokfs <dviejo@kungfusoftware.es>

* Add node selector to peer/orderer/ca

Add auth to operatorui + operatorapi

Signed-off-by: dviejokfs <dviejo@kungfusoftware.es>

* Solve issue when there's no auth in operatorui and operatorapi
Optional logoUrl

Signed-off-by: dviejokfs <dviejo@kungfusoftware.es>

* Update CRD

Signed-off-by: dviejokfs <dviejo@kungfusoftware.es>

* Add affinity to peers, orderers and CAs

Signed-off-by: dviejokfs <dviejo@kungfusoftware.es>

* Add update command + config parameters for operatorui and operatorapi

Signed-off-by: dviejokfs <dviejo@kungfusoftware.es>

* Upgrade command for peer and orderer

Signed-off-by: dviejokfs <dviejo@kungfusoftware.es>

* update docs

Signed-off-by: dviejokfs <dviejo@kungfusoftware.es>

* instructions on how to update affinity, nodeSelector and tolerations

Signed-off-by: dviejokfs <dviejo@kungfusoftware.es>

* add kubectl plugin test

Signed-off-by: dviejokfs <dviejo@kungfusoftware.es>

* install hlf-operator in Kind

Signed-off-by: dviejokfs <dviejo@kungfusoftware.es>

* change kind cluster name

Signed-off-by: dviejokfs <dviejo@kungfusoftware.es>

* update workflow

Signed-off-by: dviejokfs <dviejo@kungfusoftware.es>

* update

Signed-off-by: dviejokfs <dviejo@kungfusoftware.es>

* add repo before installing helm chart

Signed-off-by: dviejokfs <dviejo@kungfusoftware.es>

* install CRD after hlf-operator helm chart is installed

Signed-off-by: dviejokfs <dviejo@kungfusoftware.es>

* update

Signed-off-by: dviejokfs <dviejo@kungfusoftware.es>

* pullPolicy hlf-operator=IfNotPresent

Signed-off-by: dviejokfs <dviejo@kungfusoftware.es>

* create channel ci/cd

Signed-off-by: dviejokfs <dviejo@kungfusoftware.es>

* approve/commit chaincode

Signed-off-by: dviejokfs <dviejo@kungfusoftware.es>

* wait until joining the peer

Signed-off-by: dviejokfs <dviejo@kungfusoftware.es>

* fix kubectl plugin

Signed-off-by: dviejokfs <dviejo@kungfusoftware.es>

* sleep 5 seconds before testing chaincode

Signed-off-by: dviejokfs <dviejo@kungfusoftware.es>

* update

Signed-off-by: dviejokfs <dviejo@kungfusoftware.es>

* increase sleep before testing the chaincode

Signed-off-by: dviejokfs <dviejo@kungfusoftware.es>

* update node_image

Signed-off-by: dviejokfs <dviejo@kungfusoftware.es>

* add grpc proxy docs

Signed-off-by: dviejokfs <dviejo@kungfusoftware.es>

* on failure get logs from peer and orderer

Signed-off-by: dviejokfs <dviejo@kungfusoftware.es>

* fix kubectl test plugin

Signed-off-by: dviejokfs <dviejo@kungfusoftware.es>

* add MAINTAINERS.md file, fixes hyperledger#105

Signed-off-by: dviejokfs <dviejo@kungfusoftware.es>

* enroll: accept attributes/optional attributes

Signed-off-by: dviejokfs <dviejo@kungfusoftware.es>

* Use fabric-ca syntax for attributes

Signed-off-by: dviejokfs <dviejo@kungfusoftware.es>

* enroll + register attributes fabric-ca style

Signed-off-by: dviejokfs <dviejo@kungfusoftware.es>
Signed-off-by: Minollo <carlo.innocenti@oracle.com>
@dviejokfs
fix enroll
a029d8f 
Signed-off-by: dviejokfs <dviejo@kungfusoftware.es>
Signed-off-by: Minollo <carlo.innocenti@oracle.com>
@dviejokfs
fix broken link
f566726 
Signed-off-by: dviejokfs <dviejo@kungfusoftware.es>
Signed-off-by: Minollo <carlo.innocenti@oracle.com>
@dviejokfs
add new platforms for krew
2d0912d 
Signed-off-by: dviejokfs <dviejo@kungfusoftware.es>
Signed-off-by: Minollo <carlo.innocenti@oracle.com>
@dviejokfs
remove unused krew-plugin.yaml (hyperledger#107)
91b58f8 
remove freebsd from the krew plugin since it's not supported

Signed-off-by: dviejokfs <dviejo@kungfusoftware.es>
Signed-off-by: Minollo <carlo.innocenti@oracle.com>
@ZappaBoy
fixed cc-nodejs-template broken link (hyperledger#111)
1274743 
Signed-off-by: zappaboy <federico_zappone@hotmail.it>

Signed-off-by: zappaboy <federico_zappone@hotmail.it>
Signed-off-by: Minollo <carlo.innocenti@oracle.com>
@adityajoshi12
Update MAINTAINERS.md (hyperledger#116)
9270a82 
Signed-off-by: Minollo <carlo.innocenti@oracle.com>
Let users specify host aliases, so that /etc/hosts on peer containers…
4096e1c 
… can be easily managed. Peers need to be able to resolve the ordering node names - needed when using Istio and no real DNS.

Introduce peer update command - for now to let users change host aliases even after the peer has been created.

Signed-off-by: Minollo <carlo.innocenti@oracle.com>
@minollo
Copy link
Contributor Author

minollo commented Sep 24, 2022

Sure, I'll do the same for ordering nodes tomorrow.
I have executed the git commands you suggested.

Let users specify host aliases also on ordering nodes.
7181aee 
Introduce ordnode update command - for now to let users change host aliases even after the orderer node has been created.

Signed-off-by: Minollo <carlo.innocenti@oracle.com>
@minollo
Copy link
Contributor Author

minollo commented Sep 24, 2022

Added hostAliases support to ordnodes.
The code base seems to be in dire need of UTs...

@dviejokfs
Merge branch 'main' into peer-host-aliases
3a8d7c3 
Signed-off-by: dviejokfs <84456338+dviejokfs@users.noreply.github.com>
@dviejokfs
Copy link
Contributor

I'm merging the PR, thank you so much @minollo!

@dviejokfs dviejokfs merged commit 2eedeed into hyperledger:main Sep 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dviejokfs dviejokfs dviejokfs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@minollo @adityajoshi12 @dviejokfs @Wojciechowski-Marcin @ZappaBoy