Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(prism-agent): Metrics for verification flow #714

Merged
merged 4 commits into from
Sep 14, 2023
Merged

feat(prism-agent): Metrics for verification flow #714

merged 4 commits into from
Sep 14, 2023

Conversation

shotexa
Copy link
Contributor

@shotexa shotexa commented Sep 13, 2023 •
edited
Loading

Overview

Fixes ATL-5552

  • present_proof_flow_prover_presentation_pending_to_generated_ms_gauge
    • the number of milliseconds it takes for a prover to move a status of a presentation from pending to generated
  • present_proof_flow_verifier_req_pending_to_sent_ms_gauge
    • the number of milliseconds it takes for a verifier to move a status of a presentation request from pending to sent.
  • present_proof_flow_prover_presentation_generated_to_sent_ms_gauge
    • the number of milliseconds it takes for a prover to move a status of a presentation from generated to sent
  • present_proof_flow_verifier_presentation_received_to_verification_success_or_failure_ms_gauge
    • the number of milliseconds it takes for a verifier to move a status of a received presentation from received to either verified or verification failed
  • present_proof_flow_verifier_request_pending_to_sent_success_counter
    • the number of times the flow (background job) of the verifier converting a presentation request from pending to sent succeeded
  • present_proof_flow_verifier_request_pending_to_sent_failed_counter
    • the number of times the flow (background job) of the verifier converting a presentation request from pending to sent failed
  • present_proof_flow_verifier_request_pending_to_sent_all_counter
    • the number of times the flow (background job) of the verifier converting a presentation request from pending to sent ran in total
  • present_proof_flow_prover_presentation_pending_to_generated_success_counter
    • the number of times the flow (background job) of the prover converting a presentation from pending to generated succeeded
  • present_proof_flow_prover_presentation_pending_to_generated_failed_counter
    • the number of times the flow (background job) of the prover converting a presentation from pending to generated failed
  • present_proof_flow_prover_presentation_pending_to_generated_all_counter
    • the number of times the flow (background job) of the prover converting a presentation from pending to generated ran in total
  • present_proof_flow_prover_presentation_generated_to_sent_success_counter
    • the number of times the flow (background job) of the prover converting a presentation from generated to sent succeeded
  • present_proof_flow_prover_presentation_generated_to_sent_failed_counter
    • the number of times the flow (background job) of the prover converting a presentation from generated to sent failed
  • present_proof_flow_prover_presentation_generated_to_sent_all_counter
    • the number of times the flow (background job) of the prover converting a presentation from generated to sent ran in total
  • present_proof_flow_verifier_presentation_received_to_verification_success_or_failure_success_counter
    • the number of times the flow (background job) of the verifier converting a presentation from received to either verified or verification failed has succeeded
  • present_proof_flow_verifier_presentation_received_to_verification_success_or_failure_failed_counter
    • the number of times the flow (background job) of the verifier converting a presentation from received to either verified or verification failed has failed
  • present_proof_flow_verifier_presentation_received_to_verification_success_or_failure_all_counter
    • the number of times the flow (background job) of the verifier converting a presentation from received to either verified or verification failed has ran in total
  • present_proof_flow_verifier_send_presentation_request_msg_success_counter
    • the number of times verifier has successfully sent a presentation request message to prover
  • present_proof_flow_verifier_send_presentation_request_msg_failed_counter
    • the number of times verifier has failed at sending a presentation request message to prover
  • present_proof_flow_prover_send_presentation_msg_success_counter
    • he number of times prover has successfully sent a presentation message to verifier
  • present_proof_flow_prover_send_presentation_msg_failed_counter
    • the number of times prover has failed at sending a presentation message to verifier
  • present_proof_flow_verifier_send_presentation_request_msg_ms_gauge
    • the number of milliseconds it takes for a verifier to send a presentation request message to a prover
  • present_proof_flow_verifier_req_pending_to_sent_flow_ms_gauge
    • the number of milliseconds it takes to complete a flow (background job) of the verifier moving a presentation request from pending to sent
  • present_proof_flow_prover_presentation_pending_to_generated_flow_ms_gauge
    • the number of milliseconds it takes for a prover to complete a flow (background job) of presentation from pending to generated.
  • present_proof_flow_prover_send_presentation_msg_ms_gauge
    • the number of milliseconds it takes for a prover to send a presentation message to a verifier
  • present_proof_flow_prover_presentation_generated_to_sent_flow_ms_gauge
    • the number of milliseconds it takes for a prover to complete a flow (background job) of a presentation from generated to sent
  • present_proof_flow_verifier_presentation_received_to_verification_success_or_failure_flow_ms_gauge
    • the number of milliseconds it takes for a verifier to move a presentation from received to processed (either successfully verified or failed at verification) flow to complete
  • issuance_flow_did_com_exchange_job_ms_gauge
    • Issuance flow did-com exchange job running length in milliseconds
  • present_proof_flow_did_com_exchange_job_ms_gauge
    • present proof flow did-com exchange job running length in milliseconds
  • connection_flow_did_com_exchange_job_ms_gauge
    • connection flow did-com exchange job running length in milliseconds

Checklist

My PR contains...

  • No code changes (changes to documentation, CI, metadata, etc.)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes
  • are not breaking changes
  • If yes to above: I have updated the documentation accordingly

Documentation

  • My changes do not require a change to the project documentation
  • My changes require a change to the project documentation
  • If yes to above: I have updated the documentation accordingly

Tests

  • My changes can not or do not need to be tested
  • My changes can and should be tested by unit and/or integration tests
  • If yes to above: I have added tests to cover my changes
  • If yes to above: I have taken care to cover edge cases in my tests

@shotexa
Add all async metrics
d34d8e4 
Signed-off-by: Shota Jolbordi <shota.jolbordi@iohk.io>
@shotexa shotexa force-pushed the ATL-5552-metrics-for-verification-flow branch from bbdb2d6 to d34d8e4 Compare September 13, 2023 13:01
@sonarcloud
Copy link

sonarcloud bot commented Sep 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

github-actions bot commented Sep 13, 2023 •
edited
Loading

Atala PRISM Test Results

  76 files  ±0    76 suites  ±0   13m 52s ⏱️ +24s
644 tests ±0  633 ✔️ ±0  11 💤 ±0  0 ❌ ±0 
650 runs  ±0  639 ✔️ ±0  11 💤 ±0  0 ❌ ±0 

Results for commit 8e48437. ± Comparison against base commit 16000b0.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 13, 2023 •
edited
Loading

E2E Test Results

10 files  ±0  10 suites  ±0   5m 57s ⏱️ +12s
21 tests ±0  21 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
32 runs  ±0  32 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 8e48437. ± Comparison against base commit 16000b0.

♻️ This comment has been updated with latest results.

@shotexa
Flow metrics
8e8486c 
Signed-off-by: Shota Jolbordi <shota.jolbordi@iohk.io>
@shotexa
msg metrics
d02e16e 
Signed-off-by: Shota Jolbordi <shota.jolbordi@iohk.io>
@shotexa
Background job metrics
8e48437 
Signed-off-by: Shota Jolbordi <shota.jolbordi@iohk.io>
@shotexa shotexa changed the title [WIP] Metrics for verification flow feat(prism-agent) Metrics for verification flow Sep 14, 2023
@shotexa shotexa changed the title feat(prism-agent) Metrics for verification flow feat(prism-agent): Metrics for verification flow Sep 14, 2023
@shotexa shotexa merged commit 8bea26e into main Sep 14, 2023
16 of 19 checks passed
@shotexa shotexa deleted the ATL-5552-metrics-for-verification-flow branch September 14, 2023 22:50
atala-dev added a commit that referenced this pull request Sep 15, 2023
@atala-dev
chore(release): cut atala prism 1.16.0 release
0ebcd8a 
# [1.16.0](https://github.com/hyperledger-labs/open-enterprise-agent/compare/prism-agent-v1.15.0...prism-agent-v1.16.0) (2023-09-15)

### Bug Fixes

* change attribute for appuser to login ([#721](https://github.com/hyperledger-labs/open-enterprise-agent/issues/721)) ([a0e0a74](https://github.com/hyperledger-labs/open-enterprise-agent/commit/a0e0a7412172a7cc2010c39c8ee106319e710986))
* entity create and update operation failures if the walletId does… ([#718](https://github.com/hyperledger-labs/open-enterprise-agent/issues/718)) ([4fe6677](https://github.com/hyperledger-labs/open-enterprise-agent/commit/4fe66773a5aad4dc2808dad036c54c4660b3a855))
* **prism-agent:** define db app user privileges before app starts ([#722](https://github.com/hyperledger-labs/open-enterprise-agent/issues/722)) ([8039654](https://github.com/hyperledger-labs/open-enterprise-agent/commit/803965482e2634d488d2f4f364b041917be514a5))
* **prism-agent:** incorrect present proof metric name and remove connectionID from flow metrics ([#720](https://github.com/hyperledger-labs/open-enterprise-agent/issues/720)) ([52e31b0](https://github.com/hyperledger-labs/open-enterprise-agent/commit/52e31b0721d959fa53c8c49a39288b7c50d4582d))
* **prism-agent:** refine multi-tenant error response and validations ([#719](https://github.com/hyperledger-labs/open-enterprise-agent/issues/719)) ([1f9ede3](https://github.com/hyperledger-labs/open-enterprise-agent/commit/1f9ede395c4469bf26b167a6430ad42ea7cde301))
* **prism-agent:** validate application config during startup ([#712](https://github.com/hyperledger-labs/open-enterprise-agent/issues/712)) ([46fd69b](https://github.com/hyperledger-labs/open-enterprise-agent/commit/46fd69bc2416c72dd457b29f06dd181cf65f52a0))
* use postgres application user ([#717](https://github.com/hyperledger-labs/open-enterprise-agent/issues/717)) ([63403a5](https://github.com/hyperledger-labs/open-enterprise-agent/commit/63403a5d64860d4683ebaab00a86eec0578a21c0))

### Features

* **prism-agent:** Metrics for verification flow ([#714](https://github.com/hyperledger-labs/open-enterprise-agent/issues/714)) ([8bea26e](https://github.com/hyperledger-labs/open-enterprise-agent/commit/8bea26e955987e1543984e090bedad17a7863268))

Signed-off-by: Anton Baliasnikov <anton.baliasnikov@iohk.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yshyn-iohk yshyn-iohk yshyn-iohk approved these changes

@bvoiturier bvoiturier Awaiting requested review from bvoiturier

@patlo-iog patlo-iog Awaiting requested review from patlo-iog patlo-iog is a code owner

@CryptoKnightIOG CryptoKnightIOG Awaiting requested review from CryptoKnightIOG CryptoKnightIOG is a code owner

@mineme0110 mineme0110 Awaiting requested review from mineme0110 mineme0110 is a code owner

Assignees
No one assigned
Labels
Component: Cloud Agent
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shotexa @yshyn-iohk @atala-dev