feat: upgrade ZIO http client to improve performance #850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| ports: | ||
| - "9995:9187" | ||
| environment: | ||
| - DATA_SOURCE_NAME=postgresql://postgres:postgres@holder-db:5432/postgres?sslmode=disable |
Check failure
Code scanning / SonarCloud
PostgreSQL database passwords should not be disclosed
| ports: | ||
| - "9996:9187" | ||
| environment: | ||
| - DATA_SOURCE_NAME=postgresql://postgres:postgres@issuer-db:5432/postgres?sslmode=disable |
Check failure
Code scanning / SonarCloud
PostgreSQL database passwords should not be disclosed
ghost
changed the title
ghost
mentioned this pull request
ghost
changed the title
Signed-off-by: David Poltorak <david.poltorak@iohk.io>
Signed-off-by: David Poltorak <david.poltorak@iohk.io>
Signed-off-by: David Poltorak <david.poltorak@iohk.io>
Signed-off-by: David Poltorak <david.poltorak@iohk.io>
…ance Signed-off-by: David Poltorak <david.poltorak@iohk.io>
Signed-off-by: David Poltorak <david.poltorak@iohk.io>
Signed-off-by: David Poltorak <david.poltorak@iohk.io>
…requests Signed-off-by: Benjamin Voiturier <benjamin.voiturier@iohk.io>
…e) to agent's configuration file Signed-off-by: Benjamin Voiturier <benjamin.voiturier@iohk.io>
…f the active ZIO Scope Signed-off-by: Benjamin Voiturier <benjamin.voiturier@iohk.io>
Signed-off-by: David Poltorak <david.poltorak@iohk.io>
Signed-off-by: David Poltorak <david.poltorak@iohk.io>
Signed-off-by: David Poltorak <david.poltorak@iohk.io>
Signed-off-by: David Poltorak <david.poltorak@iohk.io>
Signed-off-by: David Poltorak <david.poltorak@iohk.io>
Signed-off-by: David Poltorak <david.poltorak@iohk.io>
Signed-off-by: David Poltorak <david.poltorak@iohk.io>
Signed-off-by: David Poltorak <david.poltorak@iohk.io>
Signed-off-by: David Poltorak <david.poltorak@iohk.io>
shotexa
approved these changes
Jan 24, 2024
...-agent/service/server/src/main/scala/io/iohk/atala/agent/notification/WebhookPublisher.scala
Outdated
Show resolved
Hide resolved
prism-agent/service/server/src/main/scala/io/iohk/atala/agent/server/Main.scala
Show resolved
Hide resolved
prism-agent/service/server/src/test/scala/io/iohk/atala/ZioHttpTest.scala
Outdated
Show resolved
Hide resolved
patlo-iog
approved these changes
Jan 25, 2024
pollux/lib/core/src/main/scala/io/iohk/atala/pollux/core/service/HttpURIDereferencerImpl.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: David Poltorak <david.poltorak@iohk.io>
Signed-off-by: David Poltorak <david.poltorak@iohk.io>
…error case Signed-off-by: Benjamin Voiturier <benjamin.voiturier@iohk.io>
bvoiturier
force-pushed
the
feature/http-client-performance-fix
branch
from
980ad1d
to
53ae046
Compare
|
ghost
merged commit
atala-dev
added a commit
that referenced
this pull request
Jan 25, 2024
# [1.25.0](https://github.com/hyperledger-labs/open-enterprise-agent/compare/prism-agent-v1.24.0...prism-agent-v1.25.0) (2024-01-25) ### Features * **prism-agent:** add JWT auth support for agent-admin role ([#840](https://github.com/hyperledger-labs/open-enterprise-agent/issues/840)) ([3ccd56e](https://github.com/hyperledger-labs/open-enterprise-agent/commit/3ccd56efadbbb3ea70e7ca63e9eb89564a83c02f)) * upgrade ZIO http client to improve performance ([#850](https://github.com/hyperledger-labs/open-enterprise-agent/issues/850)) ([7aa9b4c](https://github.com/hyperledger-labs/open-enterprise-agent/commit/7aa9b4c27f92b169c72a68cd4bb8f4afb63943d4)) Signed-off-by: Anton Baliasnikov <anton.baliasnikov@iohk.io>
shotexa
pushed a commit
that referenced
this pull request
Mar 6, 2024
Signed-off-by: David Poltorak <david.poltorak@iohk.io> Signed-off-by: Benjamin Voiturier <benjamin.voiturier@iohk.io> Co-authored-by: Benjamin Voiturier <benjamin.voiturier@iohk.io> Signed-off-by: Shota Jolbordi <shota.jolbordi@iohk.io>
shotexa
pushed a commit
that referenced
this pull request
Mar 6, 2024
# [1.25.0](https://github.com/hyperledger-labs/open-enterprise-agent/compare/prism-agent-v1.24.0...prism-agent-v1.25.0) (2024-01-25) ### Features * **prism-agent:** add JWT auth support for agent-admin role ([#840](https://github.com/hyperledger-labs/open-enterprise-agent/issues/840)) ([3ccd56e](https://github.com/hyperledger-labs/open-enterprise-agent/commit/3ccd56efadbbb3ea70e7ca63e9eb89564a83c02f)) * upgrade ZIO http client to improve performance ([#850](https://github.com/hyperledger-labs/open-enterprise-agent/issues/850)) ([7aa9b4c](https://github.com/hyperledger-labs/open-enterprise-agent/commit/7aa9b4c27f92b169c72a68cd4bb8f4afb63943d4)) Signed-off-by: Anton Baliasnikov <anton.baliasnikov@iohk.io> Signed-off-by: Shota Jolbordi <shota.jolbordi@iohk.io>
shotexa
pushed a commit
that referenced
this pull request
Mar 6, 2024
Signed-off-by: David Poltorak <david.poltorak@iohk.io> Signed-off-by: Benjamin Voiturier <benjamin.voiturier@iohk.io> Co-authored-by: Benjamin Voiturier <benjamin.voiturier@iohk.io> Signed-off-by: Shota Jolbordi <shota.jolbordi@iohk.io>
shotexa
pushed a commit
that referenced
this pull request
Mar 6, 2024
# [1.25.0](https://github.com/hyperledger-labs/open-enterprise-agent/compare/prism-agent-v1.24.0...prism-agent-v1.25.0) (2024-01-25) ### Features * **prism-agent:** add JWT auth support for agent-admin role ([#840](https://github.com/hyperledger-labs/open-enterprise-agent/issues/840)) ([3ccd56e](https://github.com/hyperledger-labs/open-enterprise-agent/commit/3ccd56efadbbb3ea70e7ca63e9eb89564a83c02f)) * upgrade ZIO http client to improve performance ([#850](https://github.com/hyperledger-labs/open-enterprise-agent/issues/850)) ([7aa9b4c](https://github.com/hyperledger-labs/open-enterprise-agent/commit/7aa9b4c27f92b169c72a68cd4bb8f4afb63943d4)) Signed-off-by: Anton Baliasnikov <anton.baliasnikov@iohk.io> Signed-off-by: Shota Jolbordi <shota.jolbordi@iohk.io>
shotexa
pushed a commit
that referenced
this pull request
Mar 18, 2024
Signed-off-by: David Poltorak <david.poltorak@iohk.io> Signed-off-by: Benjamin Voiturier <benjamin.voiturier@iohk.io> Co-authored-by: Benjamin Voiturier <benjamin.voiturier@iohk.io> Signed-off-by: Shota Jolbordi <shota.jolbordi@iohk.io>
shotexa
pushed a commit
that referenced
this pull request
Mar 18, 2024
# [1.25.0](https://github.com/hyperledger-labs/open-enterprise-agent/compare/prism-agent-v1.24.0...prism-agent-v1.25.0) (2024-01-25) ### Features * **prism-agent:** add JWT auth support for agent-admin role ([#840](https://github.com/hyperledger-labs/open-enterprise-agent/issues/840)) ([3ccd56e](https://github.com/hyperledger-labs/open-enterprise-agent/commit/3ccd56efadbbb3ea70e7ca63e9eb89564a83c02f)) * upgrade ZIO http client to improve performance ([#850](https://github.com/hyperledger-labs/open-enterprise-agent/issues/850)) ([7aa9b4c](https://github.com/hyperledger-labs/open-enterprise-agent/commit/7aa9b4c27f92b169c72a68cd4bb8f4afb63943d4)) Signed-off-by: Anton Baliasnikov <anton.baliasnikov@iohk.io> Signed-off-by: Shota Jolbordi <shota.jolbordi@iohk.io>
shotexa
pushed a commit
that referenced
this pull request
Mar 18, 2024
Signed-off-by: David Poltorak <david.poltorak@iohk.io> Signed-off-by: Benjamin Voiturier <benjamin.voiturier@iohk.io> Co-authored-by: Benjamin Voiturier <benjamin.voiturier@iohk.io>
shotexa
pushed a commit
that referenced
this pull request
Mar 18, 2024
Signed-off-by: David Poltorak <david.poltorak@iohk.io> Signed-off-by: Benjamin Voiturier <benjamin.voiturier@iohk.io> Co-authored-by: Benjamin Voiturier <benjamin.voiturier@iohk.io>
shotexa
pushed a commit
that referenced
this pull request
Mar 18, 2024
Signed-off-by: David Poltorak <david.poltorak@iohk.io> Signed-off-by: Benjamin Voiturier <benjamin.voiturier@iohk.io> Co-authored-by: Benjamin Voiturier <benjamin.voiturier@iohk.io> Signed-off-by: Shota Jolbordi <shota.jolbordi@iohk.io>
shotexa
pushed a commit
that referenced
this pull request
Mar 18, 2024
# [1.25.0](https://github.com/hyperledger-labs/open-enterprise-agent/compare/prism-agent-v1.24.0...prism-agent-v1.25.0) (2024-01-25) ### Features * **prism-agent:** add JWT auth support for agent-admin role ([#840](https://github.com/hyperledger-labs/open-enterprise-agent/issues/840)) ([3ccd56e](https://github.com/hyperledger-labs/open-enterprise-agent/commit/3ccd56efadbbb3ea70e7ca63e9eb89564a83c02f)) * upgrade ZIO http client to improve performance ([#850](https://github.com/hyperledger-labs/open-enterprise-agent/issues/850)) ([7aa9b4c](https://github.com/hyperledger-labs/open-enterprise-agent/commit/7aa9b4c27f92b169c72a68cd4bb8f4afb63943d4)) Signed-off-by: Anton Baliasnikov <anton.baliasnikov@iohk.io> Signed-off-by: Shota Jolbordi <shota.jolbordi@iohk.io>
shotexa
pushed a commit
that referenced
this pull request
Mar 18, 2024
Signed-off-by: David Poltorak <david.poltorak@iohk.io> Signed-off-by: Benjamin Voiturier <benjamin.voiturier@iohk.io> Co-authored-by: Benjamin Voiturier <benjamin.voiturier@iohk.io> Signed-off-by: Shota Jolbordi <shota.jolbordi@iohk.io>
shotexa
pushed a commit
that referenced
this pull request
Mar 18, 2024
Signed-off-by: David Poltorak <david.poltorak@iohk.io> Signed-off-by: Benjamin Voiturier <benjamin.voiturier@iohk.io> Co-authored-by: Benjamin Voiturier <benjamin.voiturier@iohk.io>
shotexa
pushed a commit
that referenced
this pull request
Mar 18, 2024
Signed-off-by: David Poltorak <david.poltorak@iohk.io> Signed-off-by: Benjamin Voiturier <benjamin.voiturier@iohk.io> Co-authored-by: Benjamin Voiturier <benjamin.voiturier@iohk.io> Signed-off-by: Shota Jolbordi <shota.jolbordi@iohk.io>
shotexa
pushed a commit
that referenced
this pull request
Mar 18, 2024
Signed-off-by: David Poltorak <david.poltorak@iohk.io> Signed-off-by: Benjamin Voiturier <benjamin.voiturier@iohk.io> Co-authored-by: Benjamin Voiturier <benjamin.voiturier@iohk.io> Signed-off-by: Shota Jolbordi <shota.jolbordi@iohk.io>
shotexa
pushed a commit
that referenced
this pull request
Mar 18, 2024
# [1.25.0](https://github.com/hyperledger-labs/open-enterprise-agent/compare/prism-agent-v1.24.0...prism-agent-v1.25.0) (2024-01-25) ### Features * **prism-agent:** add JWT auth support for agent-admin role ([#840](https://github.com/hyperledger-labs/open-enterprise-agent/issues/840)) ([3ccd56e](https://github.com/hyperledger-labs/open-enterprise-agent/commit/3ccd56efadbbb3ea70e7ca63e9eb89564a83c02f)) * upgrade ZIO http client to improve performance ([#850](https://github.com/hyperledger-labs/open-enterprise-agent/issues/850)) ([7aa9b4c](https://github.com/hyperledger-labs/open-enterprise-agent/commit/7aa9b4c27f92b169c72a68cd4bb8f4afb63943d4)) Signed-off-by: Anton Baliasnikov <anton.baliasnikov@iohk.io> Signed-off-by: Shota Jolbordi <shota.jolbordi@iohk.io>
shotexa
pushed a commit
that referenced
this pull request
Mar 18, 2024
Signed-off-by: David Poltorak <david.poltorak@iohk.io> Signed-off-by: Benjamin Voiturier <benjamin.voiturier@iohk.io> Co-authored-by: Benjamin Voiturier <benjamin.voiturier@iohk.io> Signed-off-by: Shota Jolbordi <shota.jolbordi@iohk.io>
shotexa
pushed a commit
that referenced
this pull request
Mar 18, 2024
Signed-off-by: David Poltorak <david.poltorak@iohk.io> Signed-off-by: Benjamin Voiturier <benjamin.voiturier@iohk.io> Co-authored-by: Benjamin Voiturier <benjamin.voiturier@iohk.io> Signed-off-by: Shota Jolbordi <shota.jolbordi@iohk.io>
shotexa
pushed a commit
that referenced
this pull request
Mar 18, 2024
Signed-off-by: David Poltorak <david.poltorak@iohk.io> Signed-off-by: Benjamin Voiturier <benjamin.voiturier@iohk.io> Co-authored-by: Benjamin Voiturier <benjamin.voiturier@iohk.io> Signed-off-by: Shota Jolbordi <shota.jolbordi@iohk.io>
shotexa
pushed a commit
that referenced
this pull request
Mar 18, 2024
Signed-off-by: David Poltorak <david.poltorak@iohk.io> Signed-off-by: Benjamin Voiturier <benjamin.voiturier@iohk.io> Co-authored-by: Benjamin Voiturier <benjamin.voiturier@iohk.io>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Previous to this PR, when using ZIO HTTP RC2 - we saw a very long delay when making HTTP requests (>2 seconds for each request) - we identified that this was not only an issue with the version of ZIO HTTP we were using but also how it was managing and shuting down the ZIO HTTP stack - essentially every request was starting and stopping the full stack.
After, with upgrading to ZIO HTTP RC4 and refactoring the ZIO layer composition for scope and client, we now see requests completing within 100 ms as the full stack doens't shutdown with every request
Also included in this PR are several improvements to the performance testing framework for error handling when polling background jobs and for managing exceptions when deserialising JSON - previously, any exception thrown was not counted as a failure in the test execution and dropped - now - metrics are available for when the background job does not complete a state transition within the given number of polls
Fixes ATL-6318
Checklist
My PR contains...
My changes...
Documentation
Tests