Consistent (& bug-fixed) sub-module #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should solve the issue Prakash run into this morning regarding docker target
build_pdo_imagesand also fixes a bug from PR #38. While testing i run again in my issues from PR #32, although the first item could be traced now to having a space in a token class which is not handled/supported and the second is some so-far-unavoidable,-known-and-ignorable issue. Didn't revisit the third bullet regarding earlier unresolved things as i guess we will revisit them (if still existing) once we start more systematic scenario testing (see issue #39) ...