Upgrade go perun to 0.8.0 #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manoranjith
force-pushed
the
upgrade-go-perun-to-0.8.0
branch
from
54467a4
to
6238bc7
Compare
Signed-off-by: Manoranjith <ponraj.manoranjitha@in.bosch.com>
- Re-org resistant transactions for ethereum backend was released in go-perun v0.8.0. - The number of blocks to wait before considering a transaction to be final has to be passed as an additional parameter to NewContractBackend function. Signed-off-by: Manoranjith <ponraj.manoranjitha@in.bosch.com>
Signed-off-by: Manoranjith <ponraj.manoranjitha@in.bosch.com>
Signed-off-by: Manoranjith <ponraj.manoranjitha@in.bosch.com>
- Previously, a channel has to be registered by explicitly calling Register, before it can be settled. - Now, settle implicitly registers the channel and the Register has been deprecated. - So, usage of Register is removed and usage of Settle is updated. - Also, update the mock tests in channel_test to test for the updated logic. Signed-off-by: Manoranjith <ponraj.manoranjitha@in.bosch.com>
- In v0.8.0, watching component was externalized from the client. - Now, it should be separately initiaized and passed on when initializing the client. Signed-off-by: Manoranjith <ponraj.manoranjitha@in.bosch.com>
Signed-off-by: Manoranjith <ponraj.manoranjitha@in.bosch.com>
- Previously, the notification was sent after the Close call returned. So, using an unbuffered channel and receiving the notification after the Close call had returned worked. - Now, the notification is sent as a part of the Close call. So, the test goes into a deadlock state where, Close call is blocked, waiting for the notification to be read and test waits for the Close call to return, only after which the notification will be read. - Fix, is to use a buffered channel for receiving notifications. So, that Close call can return and the test can read the notification. Signed-off-by: Manoranjith <ponraj.manoranjitha@in.bosch.com>
manoranjith
force-pushed
the
upgrade-go-perun-to-0.8.0
branch
from
6238bc7
to
0a5994d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade go-perun to the latest version. This also upgrades the version of go-ethereum to v1.10.12.
Apart from a few minor changes, the major changes are
Registermethod onChannel. This logic for closing a channel has been updated accordingly.Category
Implementation Task
Relevant issue
Closes #232.
Testing
All existing tests should continue to pass.
Checklist