Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify pdo-shell to enable asynchronous commits #216

Open
prakashngit opened this issue May 30, 2019 · 1 comment
Open

Modify pdo-shell to enable asynchronous commits #216

prakashngit opened this issue May 30, 2019 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@prakashngit
Copy link
Contributor

While the new commit modules are integrated into the PDO shell, the shell commits synchronously. Modify the shell to enable asynchronous commits. The following series of steps is one way to accomplish this:

  1. make wait_for_commit a separate shell command.
  2. Add a provision to specify commit dependencies as input to send command.
  3. Return commit_id after send command back to shell so as to use as input commit_dependency in a future send command
@prakashngit prakashngit added the enhancement New feature or request label May 30, 2019
@cmickeyb cmickeyb self-assigned this Jun 5, 2019
@cmickeyb
Copy link
Contributor

I don't think we need a separate command. We need to handle the "wait" flag correctly. That way, any operation that updates state can wait for the commit. If the dependencies are handled correctly (and they should be) then that will wait until all dependent transactions commit.

I think a more interesting question is whether we should provide a timeout for the wait parameter for the operations that are performing a send. Having a timeout feels like a better way to handle failure to commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants