Improved cmake for generating the configuration file #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If PDO_DEBUG_BUILD is not set or set to 0, the enclave is built with SGX_DEBUG_FLAG set to 0, and signed with the DisableDebug flag set to 1. So this commit adds one more step in the enclave cmake build to create the xml configuration file accordingly. Signed-off-by: Bruno Vavala <bruno.vavala@intel.com>
This commit adds the sgx debug flag to the TP policy, dependent on PDO_DEBUG_BUILD. Inside the TP, it adds the 64-bit flag check, and it checks that that debug flag matches the one in registered TP policy. Signed-off-by: Bruno Vavala <bruno.vavala@intel.com>
This normalizes the attestation verification checks with the TP. Signed-off-by: Bruno Vavala <bruno.vavala@intel.com>
Signed-off-by: Bruno Vavala <bruno.vavala@intel.com>
…de and disabled in HW-Release mode Signed-off-by: Bruno Vavala <bruno.vavala@intel.com>
* Simplify and document the PDO_DEBUG_BUILD configuration checks * Move all of the configuration template processing into a single cmake FUNCTION * Cmake now uses the configure_file command to perform variable substitution (no more sed) Signed-off-by: Mic Bowman <mic.bowman@intel.com>
Clean up the logic and make the setup scripts more consistent. Signed-off-by: Mic Bowman <mic.bowman@intel.com>
Make passes in environment variables to subprocesses. The extra assignment to make opts is not necessary. CMAKE_ARGS will be defined as appropriate and used in the makefiles. Signed-off-by: Mic Bowman <mic.bowman@intel.com>
Signed-off-by: Mic Bowman <mic.bowman@intel.com>
|
addressed in #490 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update cmake macros for more consistent processing of SGX configuration