Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update react native per Snyk #295

Closed
wants to merge 4 commits into from
Closed

Conversation

swcurran
Copy link
Member

Signed-off-by: Stephen Curran swcurran@gmail.com

Signed-off-by: Stephen Curran <swcurran@gmail.com>
@swcurran
Copy link
Member Author

Equivalent to #294 but with DCO signoff.

@swcurran swcurran marked this pull request as draft December 29, 2023 19:23
Signed-off-by: Stephen Curran <swcurran@gmail.com>
@swcurran
Copy link
Member Author

Also #287 #288.

@swcurran
Copy link
Member Author

Some of the tests (windows, android) failing because they want higher versions of rust — current 1.65, Windows wants 1.66 (see below), while Android wants 1.70 or higher.

What needs to be done?

error: package `relative-path v1.9.2` cannot be built because it requires rustc 1.66 or newer, while the currently active rustc version is 1.65.0
Either upgrade to rustc 1.66 or newer, or use
cargo update -p relative-path@1.9.2 --precise ver
where `ver` is the latest version of `relative-path` supporting rustc 1.65.0
Error: Process completed with exit code 1.

@TimoGlastra
Copy link
Member

TimoGlastra commented Jan 8, 2024

@berendsliedrecht @andrewwhitehead can one of you rust magicians take a look at why there are errors with the rust version? Seems to be failing in main currently as well (so unrelated to the changes in this PR)

@swcurran
Copy link
Member Author

Progress - but still not working. Now the issue seems to be a frozen-lockfile setting? @berendsliedrecht @andrewwhitehead — can one of you do what is needed to address the issue?

1s
Run pnpm install
  pnpm install
  shell: /usr/bin/bash -e {0}
  env:
    RUST_VERSION: stable 6 months ago
    CROSS_VERSION: 0.2.4
    NPM_CONFIG_USERCONFIG: /home/runner/work/_temp/.npmrc
    NODE_AUTH_TOKEN: XXXXX-XXXXX-XXXXX-XXXXX
    PNPM_HOME: /home/runner/setup-pnpm/node_modules/.bin
Scope: all 5 workspace projects
 ERR_PNPM_OUTDATED_LOCKFILE  Cannot install with "frozen-lockfile" because pnpm-lock.yaml is not up to date with packages/anoncreds-react-native-example/package.json

Note that in CI environments this setting is true by default. If you still need to run install in such cases, use "pnpm install --no-frozen-lockfile"

    Failure reason:
    specifiers in the lockfile ({"@hyperledger/anoncreds-react-native":"workspace:*","expo":"~49.0.10","expo-splash-screen":"~0.24.0","expo-status-bar":"~1.9.0","react":"18.2.0","react-native":"0.72.7","@babel/core":"^7.20.0","@babel/runtime":"^7.22.15","@types/react":"~18.2.14"}) don't match specs in package.json ({"@babel/core":"^7.20.0","@babel/runtime":"^7.22.15","@types/react":"~18.2.14","@hyperledger/anoncreds-react-native":"workspace:*","expo":"~49.0.10","expo-status-bar":"~1.10.0","react":"18.2.0","react-native":"0.73.0","expo-splash-screen":"~0.25.0"})
Error: Process completed with exit code 1.

@swcurran
Copy link
Member Author

Closing this — can’t see how to update the branch to include main updates.

@swcurran swcurran closed this Feb 16, 2024
@swcurran swcurran deleted the snyk-dec2023 branch February 16, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants