Add Node.js and React Native wrapper #58
Conversation
Signed-off-by: blu3beri <blu3beri@proton.me>
Signed-off-by: blu3beri <blu3beri@proton.me>
Signed-off-by: blu3beri <blu3beri@proton.me>
Signed-off-by: blu3beri <blu3beri@proton.me>
Signed-off-by: blu3beri <blu3beri@proton.me>
Signed-off-by: blu3beri <blu3beri@proton.me>
berendsliedrecht
changed the title
If there's a good reason for it, no issue with it. But consistency is always good I think |
| @@ -0,0 +1,26 @@ | |||
| # anoncreds-nodejs | |||
There was a problem hiding this comment.
Will you do the renaming of the folders (to anoncreds-nodejs etc..) in a follow up PR?
We should make sure that change is also made in the askar repo
| import { registerAnoncreds } from 'anoncreds-shared' | ||
| import { AnoncredsNodeJS } from 'anoncreds-nodejs' | ||
|
|
||
| registerAnoncreds({ anoncreds: AnoncredsNodeJS }) |
There was a problem hiding this comment.
We should probalby update this to work the same as the indy vdr registration (for another PR, just so we don't forgot)
| // @ts-ignore | ||
| nativeAnoncreds.anoncreds_create_schema(name, version, issuerId, attributeNames, ret) |
There was a problem hiding this comment.
Why is this ts-ignored? Is it temporary?
| @@ -0,0 +1,674 @@ | |||
| /* eslint-disable @typescript-eslint/ban-ts-comment */ | |||
There was a problem hiding this comment.
Yeah I believe there were some issues with ref-napi giving some "funky" types. Will do a cleanup PR after this one.
|
|
||
| const attributeNames = StringListStruct({ | ||
| count: Object.keys(options.attributeRawValues).length, | ||
| // @ts-ignore |
There was a problem hiding this comment.
Won't comment on the ts-ignores anymore. If temporary okay, but we should really avoid them. If there's a typing issue we should add a method that handles that issue and reuse that everywhere.
| anoncreds_create_credential_request: [ | ||
| FFI_ERRORCODE, | ||
| [ | ||
| FFI_STRING, | ||
| FFI_OBJECT_HANDLE, | ||
| FFI_OBJECT_HANDLE, | ||
| FFI_STRING, | ||
| FFI_OBJECT_HANDLE, | ||
| FFI_OBJECT_HANDLE_PTR, | ||
| FFI_OBJECT_HANDLE_PTR, | ||
| ], | ||
| ], |
There was a problem hiding this comment.
Maybe a lot of work, but if we were to assign custom types based on the ffi types , it would be much easier which parameters should be passed.
E.g. let's say we have a method that takes a credentialDefinitionId. Currently it would be typed as:
anoncreds_create_credential_request: [
FFI_ERRORCODE,
[
FFI_STRING,
],
],
However we could also write it like this:
const FFI_CREDENTIAL_DEFINITION_ID = FFI_STRING
anoncreds_create_credential_request: [
FFI_ERRORCODE,
[
FFI_CREDENTIAL_DEFINITION_ID,
],
],
Just a thought, maybe impractical
There was a problem hiding this comment.
Yeah I think I had that for a bit, but keeping that across all the shared components was a huuuuge amount of effort. It makes sense a lot for readability, but it will only be needed in the NodeJsAnoncreds package, so it was not worth the effort me.
|
I will merge this for now. All the issues you mentioned are noted as issues and will be resolved incrementally. This was supposed to be just a move, but I wanted to see if I could get the tests working as well. |
closes #54
closes #28
indy-shared-rs.indy-credxtoanoncredsAnoncredsand notAnonCredslike in AFJ. @TimoGlastra any issues with this?