Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodejs release ready #81

Merged

Conversation

berendsliedrecht
Copy link
Contributor

@berendsliedrecht berendsliedrecht commented Jan 24, 2023

closes #66

  • chore(js): disable releasing react-native package
  • chore(js): use the @hyperledger prefix for the packages
  • chore(js): rename to have anoncreds- prefix
  • fix(js): make sure everything works with the anoncreds prefix
  • chore(js): set the correct version
  • chore: set the correct version
  • fix(js): register module like indy-vdr and aries-askar
  • chore(js): added v prefix for the version
  • docs(js): added READMEs
  • chore(js): updated the urls for the packages
  • chore(js): correct include files and added post install script

Work funded by the Government of Ontario.

Signed-off-by: blu3beri <blu3beri@proton.me>
Work funded by the Government of Ontario.

Signed-off-by: blu3beri <blu3beri@proton.me>
Work funded by the Government of Ontario.

Signed-off-by: blu3beri <blu3beri@proton.me>
Work funded by the Government of Ontario.

Signed-off-by: blu3beri <blu3beri@proton.me>
Work funded by the Government of Ontario.

Signed-off-by: blu3beri <blu3beri@proton.me>
Signed-off-by: blu3beri <blu3beri@proton.me>
Work funded by the Government of Ontario.

Signed-off-by: blu3beri <blu3beri@proton.me>
wrappers/javascript/anoncreds-nodejs/README.md Outdated Show resolved Hide resolved
wrappers/javascript/anoncreds-nodejs/package.json Outdated Show resolved Hide resolved
wrappers/javascript/anoncreds-nodejs/tsconfig.json Outdated Show resolved Hide resolved
Work funded by the Government of Ontario.

Signed-off-by: blu3beri <blu3beri@proton.me>
Work funded by the Government of Ontario.

Signed-off-by: blu3beri <blu3beri@proton.me>
Work funded by the Government of Ontario.

Signed-off-by: blu3beri <blu3beri@proton.me>
Work funded by the Government of Ontario.

Signed-off-by: blu3beri <blu3beri@proton.me>
@berendsliedrecht
Copy link
Contributor Author

berendsliedrecht commented Jan 24, 2023

Sadly I could not seem to include the ../../../LICENSE in the packed version of the library, I guess it must be inside the package. So I added the apache-2.0 license from the root to all the other packages.

Work funded by the Government of Ontario.

Signed-off-by: blu3beri <blu3beri@proton.me>
@berendsliedrecht
Copy link
Contributor Author

@ryjones hi, can you add the NPM_TOKEN secret? Thank you!

@berendsliedrecht
Copy link
Contributor Author

CI is failing right now because, the error message is very ambiguous, the nodejs package has an install script which tried to fetch a dependency, but that will not work because we did not create the first release yet. Before this script was added, it did work.

@ryjones
Copy link
Member

ryjones commented Jan 25, 2023

@ryjones hi, can you add the NPM_TOKEN secret? Thank you!

@blu3beri done

@TimoGlastra
Copy link
Member

@blu3beri you need to add the following file: https://github.com/hyperledger/indy-vdr/blob/main/wrappers/javascript/indy-vdr-nodejs/native/indy_vdr.node

This prevents it from downloading it when you clone the repo and do install. It's not published to the npm package though and therefore it will install it when you install it from npm

TimoGlastra and others added 2 commits January 25, 2023 13:19
Work funded by the Government of Ontario.

Signed-off-by: blu3beri <blu3beri@proton.me>
@berendsliedrecht berendsliedrecht merged commit 3a33b71 into hyperledger:main Jan 25, 2023
@berendsliedrecht berendsliedrecht deleted the nodejs-release-ready branch January 25, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable post install script for anoncreds-nodejs
3 participants