Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add issuer identifier #126

Merged
merged 6 commits into from
Jan 23, 2023
Merged

add issuer identifier #126

merged 6 commits into from
Jan 23, 2023

Conversation

TimoGlastra
Copy link
Member

Adds an issuerId property to all anoncreds ledger objects. The revocation status list is still todo, but it needs #125 so I'll add it in another PR.

For now just added a short section that the anoncreds method must define what the issuerId is, and how you can guarantee only the controller of the identifier can / is allowed to publish objects with an issuerId they control.

Fixes #116

Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
spec/anoncreds_methods.md Outdated Show resolved Hide resolved
spec/data_flow_setup.md Outdated Show resolved Hide resolved
@@ -433,6 +438,7 @@ Sovrin MainNet and instance of Hyperledger Indy.

```json
{
"issuerId": "Gs6cQcvrtWoZKsbBhD3dQJ",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again -- not a good example.

@swcurran
Copy link
Member

swcurran commented Jan 9, 2023

Discussed on 2023.01.09 AnonCreds Spec Working Group Meeting -- no objections to merging this once @TimoGlastra has made the final few updates.

Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
@swcurran swcurran merged commit e1169f5 into hyperledger:main Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an issuerId object to all anoncreds registry objects
2 participants