Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

javascript: add issue credential, present proof #158

Merged
merged 1 commit into from
Feb 15, 2021

Conversation

TimoGlastra
Copy link
Member

  • Update Aries Framework JavaScript (will add javascript-master dockerfile soon)
  • Add Issue Credential, Present Proof
  • Add github actions runners for javascript-javascript acapy-javascript javascript-dotnet
    • I'm not sure if the allure project will automatically be created @nodlesh

Signed-off-by: Timo Glastra <timo@animo.id>
@swcurran
Copy link
Member

@TimoGlastra -- looks good. It would be good to include a line about what tests that you expect to run with this, but I ran them all and same the ones working.

@nodlesh -- we have to look at the tags, I think. It would certainly be good to have "revocation" as a tag, so we can say '-t ~@revocation` and not run any of those.

Copy link
Member

@swcurran swcurran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ran through all the tests.

@swcurran swcurran merged commit 749f03e into hyperledger:master Feb 15, 2021
@TimoGlastra TimoGlastra deleted the afj branch February 16, 2021 09:43
@nodlesh
Copy link
Contributor

nodlesh commented Feb 16, 2021

@nodlesh -- we have to look at the tags, I think. It would certainly be good to have "revocation" as a tag, so we can say '-t ~@revocation` and not run any of those.

We do have a @RFC0011 and a @RFC0183 tag. Those will remove the execution of revocation tests.

@nodlesh
Copy link
Contributor

nodlesh commented Feb 16, 2021

Allure projects javascript, acapy-b-javascript, & javascript-b-dotnet created.

Matt-Spence pushed a commit to Matt-Spence/aries-agent-test-harness that referenced this pull request Jun 29, 2021
javascript: add issue credential, present proof
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants