Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #579 - Creating project before uploading allure results #582

Merged
merged 1 commit into from
Oct 21, 2022

Conversation

PatStLouis
Copy link
Contributor

Signed-off-by: Patrick St-Louis patrick.st-louis@idlab.org

This PR adds a call to the /allure-docker-service/projects api endpoint before uploading the results. If the project already exists, it will simply upload the results to the existing project.

Signed-off-by: Patrick St-Louis <patrick.st-louis@idlab.org>
@PatStLouis
Copy link
Contributor Author

@swcurran here is a signed PR. The afgo agent is still having a hard time building, with the following errors.

# github.com/hyperledger/aries-framework-go/pkg/didcomm/protocol/didexchange
../../pkg/didcomm/protocol/didexchange/didex_interop.go:62:17: undefined: didcommutil
note: module requires Go 1.19
make: *** [Makefile:135: agent-rest-acapy-interop] Error 2
The command "/bin/sh -c GO_TAGS=${GO_TAGS} GOPROXY=${GOPROXY} make agent-rest-acapy-interop" returned a non-zero code: 2
Docker image build failed.
Error: Process completed with exit code 1.

Would bumping the version of ARG GO_VER=1.16 to ARG GO_VER=1.19 in the Dockerfile.afgo-interop and Dockerfile.afgo-master fix this? Not sure if this would break other stuff

@swcurran swcurran requested a review from nodlesh October 21, 2022 14:05
@swcurran
Copy link
Member

Aware of the AF-Go issue -- I've created this issue for it in the AF-Go repo: hyperledger-archives/aries-framework-go#3396

Thanks for the fix! @nodlesh -- can you please review?

Copy link
Contributor

@nodlesh nodlesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great @PatStLouis.

So the call to create the project doesn't do anything if it finds it already there? If so, this is much simpler than I thought, and absolutely meets the criteria for #579.

@nodlesh nodlesh merged commit b01a903 into hyperledger:main Oct 21, 2022
@PatStLouis
Copy link
Contributor Author

This is what we are using internally and what you describe is the observed behavior. It makes a post request to create the project, if the project already exists it will simply carry on and append the results to the existing project.

In case the project already exists, it will return a 400 {"message": "project_id '<project_id>' is existent"}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants