Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update afgo images to go 1.19 #602

Merged
merged 1 commit into from
Nov 29, 2022
Merged

Conversation

Moopli
Copy link
Contributor

@Moopli Moopli commented Nov 29, 2022

Signed-off-by: Filip Burlacu filip.burlacu@securekey.com

Signed-off-by: Filip Burlacu <filip.burlacu@securekey.com>
@Moopli
Copy link
Contributor Author

Moopli commented Nov 29, 2022

@swcurran a recent afgo PR should fix one build issue (hyperledger-archives/aries-framework-go#3396), and this PR should fix the other. There have been enough changes since that tests are quite broken, but at least we'll see the deltas again.

@swcurran
Copy link
Member

Looks good. I've run the afgo runset and a number of tests passed, which is good. I'm now running acapy-afgo, and it is also looking good -- it's building again, and a couple of tests have passed at least.

Here are the results from the afgo runset:

Failing scenarios:
  features/0023-did-exchange.feature:45  Establish a connection with DID Exchange between two agents with an implicit invitation
  features/0036-issue-credential.feature:23  Issue a credential with the Holder beginning with a proposal with DID Exchange Connection
  features/0453-issue-credential-v2.feature:53  Issue a JSON-LD credential with the Holder beginning with a proposal -- @2.1 
  features/0453-issue-credential-v2.feature:58  Issue a JSON-LD credential with the Holder beginning with a proposal -- @3.1 
  features/0453-issue-credential-v2.feature:63  Issue a JSON-LD credential with the Holder beginning with a proposal -- @4.1 
  features/0453-issue-credential-v2.feature:68  Issue a JSON-LD credential with the Holder beginning with a proposal -- @5.1 
  features/0454-present-proof-v2.feature:26  Present Proof of specific types and proof is acknowledged with a Drivers License credential type with a DID Exchange Connection -- @2.1 
  features/0454-present-proof-v2.feature:31  Present Proof of specific types and proof is acknowledged with a Drivers License credential type with a DID Exchange Connection -- @3.1 
  features/0454-present-proof-v2.feature:36  Present Proof of specific types and proof is acknowledged with a Drivers License credential type with a DID Exchange Connection -- @4.1 
  features/0454-present-proof-v2.feature:41  Present Proof of specific types and proof is acknowledged with a Drivers License credential type with a DID Exchange Connection -- @5.1 
  features/0454-present-proof-v2.feature:65  Present Proof of specific types and proof is acknowledged with a Citizenship credential type with a DID Exchange Connection -- @1.1 
  features/0454-present-proof-v2.feature:70  Present Proof of specific types and proof is acknowledged with a Citizenship credential type with a DID Exchange Connection -- @2.1 
  features/0454-present-proof-v2.feature:75  Present Proof of specific types and proof is acknowledged with a Citizenship credential type with a DID Exchange Connection -- @3.1 
  features/0454-present-proof-v2.feature:80  Present Proof of specific types and proof is acknowledged with a Citizenship credential type with a DID Exchange Connection -- @4.1 
  features/issue-credential-v3.feature:5  WACI issuance flow
  features/oob-v2.feature:5  Establish a connection between two agents using DIDComm V2
  features/present-proof-v3.feature:29  Present Proof of specific types and proof is acknowledged with a Citizenship credential type with a DID Exchange Connection -- @1.1 
  features/present-proof-v3.feature:34  Present Proof of specific types and proof is acknowledged with a Citizenship credential type with a DID Exchange Connection -- @2.1 

3 features passed, 7 failed, 4 skipped
27 scenarios passed, 18 failed, 108 skipped
263 steps passed, 18 failed, 1039 skipped, 0 undefined
Took 21m8.417s

@swcurran swcurran merged commit 80c0410 into hyperledger:main Nov 29, 2022
@swcurran
Copy link
Member

Here are the acapy-afgo runset results:

Failing scenarios:
  features/0023-did-exchange.feature:45  Establish a connection with DID Exchange between two agents with an implicit invitation
  features/0025-didcomm-transports.feature:23  Create DIDExchange connection between two agents with overlapping transports -- @1.1 DIDExchange connection with both agents using HTTP for inbound and outbound transport
  features/0453-issue-credential-v2.feature:48  Issue a JSON-LD credential with the Holder beginning with a proposal -- @1.1 
  features/0453-issue-credential-v2.feature:53  Issue a JSON-LD credential with the Holder beginning with a proposal -- @2.1 
  features/0453-issue-credential-v2.feature:58  Issue a JSON-LD credential with the Holder beginning with a proposal -- @3.1 
  features/0454-present-proof-v2.feature:26  Present Proof of specific types and proof is acknowledged with a Drivers License credential type with a DID Exchange Connection -- @2.1 
  features/0454-present-proof-v2.feature:31  Present Proof of specific types and proof is acknowledged with a Drivers License credential type with a DID Exchange Connection -- @3.1 
  features/0454-present-proof-v2.feature:46  Present Proof of specific types and proof is acknowledged with a Drivers License credential type with a DID Exchange Connection -- @6.1 
  features/0454-present-proof-v2.feature:65  Present Proof of specific types and proof is acknowledged with a Citizenship credential type with a DID Exchange Connection -- @1.1 
  features/0454-present-proof-v2.feature:70  Present Proof of specific types and proof is acknowledged with a Citizenship credential type with a DID Exchange Connection -- @2.1 
  features/0454-present-proof-v2.feature:85  Present Proof of specific types and proof is acknowledged with a Citizenship credential type with a DID Exchange Connection -- @5.1 

0 features passed, 4 failed, 10 skipped
3 scenarios passed, 11 failed, 139 skipped
44 steps passed, 11 failed, 1265 skipped, 0 undefined
Took 1m12.246s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants