Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored ngrok support with necessary AuthToken #758

Merged
merged 3 commits into from Jan 8, 2024

Conversation

nodlesh
Copy link
Contributor

@nodlesh nodlesh commented Jan 5, 2024

This PR refactors ngrok support in AATH. As of Dec 26 2023, AATH stopped working with ngrok because of the enforcement of an AuthToken to start ngrok services. Users that need to use ngrok support in AATH will need to acquire, either free or paid for, an AuthToken from ngrok.

At this point forward, if you are using the -n option on the manage script, you will also have to set an NGROK_AUTHTOKEN environment variable. This can be done like this for example;

NGROK_AUTHTOKEN=2ZrwpFakeAuthToken_W4VDBxavAzdB5K3wsDGz LEDGER_URL_CONFIG=http://test.bcovrin.vonx.io TAILS_SERVER_URL_CONFIG=https://tails.vonx.io AGENT_CONFIG_FILE=/aries-backchannels/acapy/auto_issuer_config.yaml ./manage start -a acapy-main -b acapy-main -n

Behavioural changes in this PR are as follows:

  • There is now one ngrok container started instead of one for every Aries agent.
  • This ngrok container starts all the tunnels needed. Note, if you have a free ngrok account and associated AuthToken then you will only be able to start 3 tunnels in the ngrok container. This shouldn't be a problem since we have not come into a use case where more than 2 are needed.

Closes #757

Copy link
Member

@WadeBarnes WadeBarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any changes needed to the GHA workflows to inject the required token?

One minor working suggestion below.

MOBILE_AGENT_TESTING.md Outdated Show resolved Hide resolved
Signed-off-by: Sheldon Regular <sheldon.regular@gmail.com>
Signed-off-by: Sheldon Regular <sheldon.regular@gmail.com>
@nodlesh
Copy link
Contributor Author

nodlesh commented Jan 8, 2024

I'm working on an issue I just found when running this with the @MobileTests tag meant for running these tests with a device in hand.

Signed-off-by: Sheldon Regular <sheldon.regular@gmail.com>
@nodlesh nodlesh force-pushed the feature-peer-did-transition branch from c627e4b to ce2f963 Compare January 8, 2024 19:38
@nodlesh
Copy link
Contributor Author

nodlesh commented Jan 8, 2024

Updated the md. Also fixed the mobile backchannel build which was failing when I went to test this. Bumped the backchannel to the same Python version/image as the ACA-Py backchannel.

@nodlesh nodlesh merged commit 55537c5 into hyperledger:main Jan 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot start test agents with ngrok anymore, ngrok now requires an authtoken
3 participants