-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Fetch SQL queries in Postgres backend #196
Conversation
3ace298
to
14b382e
Compare
@andrewwhitehead — any idea why the tests failed? Doesn’t look like it would be related to the change? Fun PR — thanks! |
It appears that the latest ring dependency breaks support for the manylinux aarch64 environment we are using (briansmith/ring#1728). We could update to |
Small update - I've made some progress on building a benchmark using Criterion to test if there's any benefit in the refactored SQL queries. Preliminary results are looking good. Red = Old SQL I'll work on a larger benchmark - pre-populate with 50000 profiles and then compare the SQL queries. Correction: |
ab73e4a
to
b8c18d3
Compare
@swcurran, @andrewwhitehead, is there a channel on the Hyperledger Discord we could chat in? |
There is an aries-askar channel on the Hyperledger Discord Server (invite: https://discord.gg/hyperledger) that I just created that we can use. Should have been created long ago :-). |
94f4d97
to
3d2d75f
Compare
Signed-off-by: Robbie Blaine <robbieblaine.rb@gmail.com>
3d2d75f
to
5203853
Compare
An attempt at some optimizations on the
FETCH_QUERY
andFETCH_QUERY_UPDATE
Postgres queries.Opening as a draft PR while I work on figuring out a way to benchmark the updated queries.
According to GPT:
Please be as pedantic as possible (
-Wclippy::pedantic -Wclippy::nursery
).Related to #195