chore(js): add expo example app and move to pnpm #247

berendsliedrecht · 2024-05-08T12:51:14Z

supersedes chore(js): use pnpm as the package manager #246
builds on top of P256 keys using Secure Enclave and Android StrongBox #245
Moves to pnpm from yarn
Update lerna from 7 to 8 to fix issue with building
Added react native (expo) example app

Rust side changes

Updated the secure-env library as there were some issues with Android in a non cargo-ndk managed app.
Added a HasKeyBackend trait which defaults to KeyBackend::Software. This is done so we can correctly create P256 Software vs Hardware keys.

berendsliedrecht · 2024-05-10T11:08:29Z

@swcurran snyk seems to fail, but I cannot access the project page on their website. Could you help with this? I just need to know which dependencies are the issue.

swcurran · 2024-05-10T14:13:06Z

@berendsliedrecht — is this helpfuil? Not sure it is what you want. It what I can see, and the only related link is the settings gear, but that doesn’t seem to be helpful.

berendsliedrecht · 2024-05-10T15:43:41Z

@berendsliedrecht — is this helpfuil? Not sure it is what you want. It what I can see, and the only related link is the settings gear, but that doesn’t seem to be helpful.

Hmm it wants it to be built with yarn. Do we have some setting to set the package manager? Pnpm-lock.yaml is equal to yarn.lock

swcurran · 2024-05-10T17:20:35Z

I don’t know about any of this stuff, so stumbling around. When I hit the “gear” from the image above, and then in the top right “Open in GitHub” — it takes me to this page: https://github.com/hyperledger/aries-askar/blob/main/wrappers/javascript/package.json where there are a number of references to yarn. Is that file correct?

TimoGlastra · 2024-05-13T04:24:08Z

Requested us to be added @berendsliedrecht: hyperledger/governance#259

TimoGlastra

LGTM, nice 👍

TimoGlastra · 2024-05-14T12:42:40Z

wrappers/javascript/.eslintrc.yaml

@@ -0,0 +1,71 @@
+root: true


might be nice to also move this to biome so we can drop prettier + eslint

Yes, wanted to do that at a later stage.

TimoGlastra · 2024-05-14T12:43:12Z

wrappers/javascript/package.json

  "repository": {
    "type": "git",
-    "url": "https://github.com/hyperledger/aries-askar",
+    "url": "https://github.com/hyperledger/aries-askar-rs",


Suggested change

"url": "https://github.com/hyperledger/aries-askar-rs",

"url": "https://github.com/hyperledger/aries-askar",

TimoGlastra · 2024-05-14T12:43:40Z

wrappers/javascript/packages/aries-askar-nodejs/src/ffi/serialize.ts

+      ? number
+      : Type[Property] extends Record<string, unknown> | unknown[]
+        ? string
+        : Type[Property] extends Buffer | Uint8Array | Key | ArcHandle | Jwk
+          ? Buffer
+          : Type[Property] extends Callback
+            ? Callback
+            : Type[Property] extends CallbackWithResponse
+              ? CallbackWithResponse
+              : Type[Property] extends boolean | undefined
+                ? number
+                : Type[Property] extends unknown[] | undefined
+                  ? string
+                  : Type[Property] extends Record<string, unknown> | undefined
+                    ? string
+                    : Type[Property] extends Date | undefined
+                      ? number
+                      : Type[Property] extends string | undefined
+                        ? string
+                        : Type[Property] extends number | undefined
+                          ? number
+                          : Type[Property] extends Uint8Array | undefined
+                            ? Buffer
+                            : unknown


Love it 😆

berendsliedrecht · 2024-05-15T11:40:44Z

Going a bit through the Snyk issue again, it seems that they do not have support for PNPM (snyk/nodejs-lockfile-parser#111). Can we disable it for the JS projects and just have dependabot deal with vunelerabilities?

@swcurran

swcurran · 2024-05-15T14:42:27Z

@WadeBarnes — can you help here? You have a way better handle on this than I. Thanks!

swcurran · 2024-05-15T14:43:22Z

@WadeBarnes — I mean about the Snyk comment — #247 (comment)

WadeBarnes · 2024-05-15T15:00:53Z

It seems Snyk is adding support for pnpm; snyk/nodejs-lockfile-parser#111 (comment)

Some additional questions to establish some background (mostly for me since the setup is not obvious):

How does Snyk come into play with what's being discussed here?
How is Snyk integrated with the project?
- At what level?
- Directly or indirectly?

Signed-off-by: Berend Sliedrecht <sliedrecht@berend.io>

TimoGlastra

LGTM except for pushing android/ios folders for example app

TimoGlastra · 2024-06-04T11:27:29Z

...ascript/packages/aries-askar-react-native-example/android/app/src/main/res/values/colors.xml

@@ -0,0 +1,6 @@
+<resources>


Can we make the example app an Expo app and not push the prebulid outputs?

Ah ofcourse! I think the gitignore was picked up later while rebasing. Shouldn't have pushed it!

berendsliedrecht · 2024-06-04T11:48:59Z

@andrewwhitehead could you review the rust side? Quite minimal changes, mainly a new trait HasKeyBackend which every key implements with a default of KeyBackend::Software.

TimoGlastra · 2024-06-04T12:53:58Z

DCO seems to be messed up. Maybe you need to squash and force push?

Signed-off-by: Berend Sliedrecht <sliedrecht@berend.io>

berendsliedrecht · 2024-06-07T08:19:27Z

@WadeBarnes

Some additional questions to establish some background (mostly for me since the setup is not obvious):

How does Snyk come into play with what's being discussed here?
How is Snyk integrated with the project?
At what level?
Directly or indirectly?

Sadly I am not a Snyk expert so I cannot answer these questions. I think it is integrated indirectly just by being under the Hyperledger organization (not a 100% sure, but I cannot seem to find any Snyk setup in this repo). IMO we can just disable and let dependabot deal with the specific issues for JS. This is blocking quite some work now, also for Credo.

WadeBarnes · 2024-06-07T13:19:18Z

@ryjones, Do you have any thoughts, comments, or recommendations on the Snyk topic?

ryjones · 2024-06-07T14:58:26Z

wrappers/javascript/package.json

Missing required yarn.lock.

I've removed the integration

TimoGlastra · 2024-06-08T13:16:14Z

@berendsliedrecht Made a similar PR in indy vdr repo, but also updated to Biome and vitest there (lest config/setup). Maybe we can do the same here as well.

berendsliedrecht force-pushed the pnpm-and-example-app branch 3 times, most recently from c23380e to 7728f98 Compare May 8, 2024 14:39

berendsliedrecht mentioned this pull request May 8, 2024

P256 keys using Secure Enclave and Android StrongBox #245

Merged

berendsliedrecht force-pushed the pnpm-and-example-app branch 2 times, most recently from 1ce7395 to 1636421 Compare May 10, 2024 11:07

TimoGlastra mentioned this pull request May 13, 2024

Add @berendsliedrecht and @timoglastra to Hyperledger Snyk hyperledger/governance#259

Closed

berendsliedrecht force-pushed the pnpm-and-example-app branch from 11a972a to c522cb2 Compare May 14, 2024 10:59

berendsliedrecht marked this pull request as ready for review May 14, 2024 10:59

TimoGlastra previously approved these changes May 14, 2024

View reviewed changes

berendsliedrecht dismissed TimoGlastra’s stale review via 074d20b May 15, 2024 11:32

swcurran requested a review from WadeBarnes May 15, 2024 14:42

berendsliedrecht force-pushed the pnpm-and-example-app branch 4 times, most recently from a8cf96c to b4851df Compare May 22, 2024 10:46

berendsliedrecht marked this pull request as draft May 22, 2024 10:53

berendsliedrecht force-pushed the pnpm-and-example-app branch 2 times, most recently from f3bd36e to dbd5a9b Compare May 22, 2024 13:53

berendsliedrecht marked this pull request as ready for review June 4, 2024 11:19

chore(js): migrate to pnpm

602a512

Signed-off-by: Berend Sliedrecht <sliedrecht@berend.io>

berendsliedrecht force-pushed the pnpm-and-example-app branch 2 times, most recently from cd6d0c9 to 849cd67 Compare June 4, 2024 11:24

TimoGlastra previously approved these changes Jun 4, 2024

View reviewed changes

berendsliedrecht dismissed TimoGlastra’s stale review via b262c6a June 4, 2024 11:29

berendsliedrecht force-pushed the pnpm-and-example-app branch 2 times, most recently from b262c6a to add1389 Compare June 4, 2024 11:43

berendsliedrecht enabled auto-merge (rebase) June 4, 2024 11:43

berendsliedrecht force-pushed the pnpm-and-example-app branch from add1389 to 731b98d Compare June 4, 2024 11:45

berendsliedrecht disabled auto-merge June 4, 2024 11:49

berendsliedrecht requested a review from andrewwhitehead June 4, 2024 11:49

berendsliedrecht force-pushed the pnpm-and-example-app branch 2 times, most recently from b0fce3d to a120fec Compare June 4, 2024 12:29

TimoGlastra approved these changes Jun 4, 2024

View reviewed changes

berendsliedrecht and others added 4 commits June 4, 2024 15:05

chore(js): include React Native Expo example app

921d18d

Signed-off-by: Berend Sliedrecht <sliedrecht@berend.io>

fix: hold reference to which backend is used for any key

458d887

Signed-off-by: Berend Sliedrecht <sliedrecht@berend.io>

chore(js): migrate to pnpm

678bbfc

Signed-off-by: Berend Sliedrecht <sliedrecht@berend.io>

chore: update secure env and call set_env for jni

608507f

Signed-off-by: Berend Sliedrecht <sliedrecht@berend.io>

berendsliedrecht force-pushed the pnpm-and-example-app branch from a120fec to 608507f Compare June 4, 2024 13:05

Merge branch 'main' into pnpm-and-example-app

de017ae

TimoGlastra merged commit 9ff1271 into hyperledger:main Jun 8, 2024
29 of 30 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(js): add expo example app and move to pnpm #247

chore(js): add expo example app and move to pnpm #247

berendsliedrecht commented May 8, 2024 •

edited

Loading

berendsliedrecht commented May 10, 2024

swcurran commented May 10, 2024 •

edited

Loading

berendsliedrecht commented May 10, 2024

swcurran commented May 10, 2024

TimoGlastra commented May 13, 2024

TimoGlastra left a comment

TimoGlastra May 14, 2024

berendsliedrecht May 14, 2024

TimoGlastra May 14, 2024

TimoGlastra May 14, 2024

berendsliedrecht commented May 15, 2024 •

edited

Loading

swcurran commented May 15, 2024

swcurran commented May 15, 2024

WadeBarnes commented May 15, 2024

TimoGlastra left a comment

TimoGlastra Jun 4, 2024

berendsliedrecht Jun 4, 2024

berendsliedrecht commented Jun 4, 2024

TimoGlastra commented Jun 4, 2024

berendsliedrecht commented Jun 7, 2024

WadeBarnes commented Jun 7, 2024 •

edited

Loading

ryjones commented Jun 7, 2024 •

edited

Loading

TimoGlastra commented Jun 8, 2024

	"url": "https://github.com/hyperledger/aries-askar-rs",
	"url": "https://github.com/hyperledger/aries-askar",

chore(js): add expo example app and move to pnpm #247

chore(js): add expo example app and move to pnpm #247

Conversation

berendsliedrecht commented May 8, 2024 • edited Loading

Rust side changes

berendsliedrecht commented May 10, 2024

swcurran commented May 10, 2024 • edited Loading

berendsliedrecht commented May 10, 2024

swcurran commented May 10, 2024

TimoGlastra commented May 13, 2024

TimoGlastra left a comment

Choose a reason for hiding this comment

TimoGlastra May 14, 2024

Choose a reason for hiding this comment

berendsliedrecht May 14, 2024

Choose a reason for hiding this comment

TimoGlastra May 14, 2024

Choose a reason for hiding this comment

TimoGlastra May 14, 2024

Choose a reason for hiding this comment

berendsliedrecht commented May 15, 2024 • edited Loading

swcurran commented May 15, 2024

swcurran commented May 15, 2024

WadeBarnes commented May 15, 2024

TimoGlastra left a comment

Choose a reason for hiding this comment

TimoGlastra Jun 4, 2024

Choose a reason for hiding this comment

berendsliedrecht Jun 4, 2024

Choose a reason for hiding this comment

berendsliedrecht commented Jun 4, 2024

TimoGlastra commented Jun 4, 2024

berendsliedrecht commented Jun 7, 2024

WadeBarnes commented Jun 7, 2024 • edited Loading

ryjones commented Jun 7, 2024 • edited Loading

TimoGlastra commented Jun 8, 2024

berendsliedrecht commented May 8, 2024 •

edited

Loading

swcurran commented May 10, 2024 •

edited

Loading

berendsliedrecht commented May 15, 2024 •

edited

Loading

WadeBarnes commented Jun 7, 2024 •

edited

Loading

ryjones commented Jun 7, 2024 •

edited

Loading