incompatible shell

[nobody4t]

I try to run through the docs. when to run run_tests, I got the error:

./scripts/run_tests: [[: not found

As I found the in the script that this shell script just uses sh not bash. And [[ ... ]] is not good. I would advise to the syntax consistent.

My os is: ubuntu 18.04, bash and amd64. Is this anything which should be fixed?

[swcurran]

Definitely should be bash. Will need to address this.

[nobody4t]

Yes, I think so. Let me make a pr for this.

[swcurran]

FYI - here is the low down on single vs. double square braces in bash:

https://stackoverflow.com/questions/13542832/difference-between-single-and-double-square-brackets-in-bash

We should be using just a single [ in the scripts and definitely all should be running bash only. If it works with other shells, that's good, but bash is the target.

I'm going to update the demo script (./run_demo in the demo folder), but the rest should be addressed as well.

[nobody4t]

@swcurran
I have composed a patch for this. If you did not do it, let me do this.

[swcurran]

Sure - go for it. Thanks! @dongwangdw

[nobody4t]

@swcurran

#72

[nrempel]

Thank you @dongwangdw! The patch has been merged and is available in the latest release.